Repository navigation
fix(ci): retry CPM bootstrap download on transient failures - #53
Merged
Merged
Conversation
CMake file(DOWNLOAD) with EXPECTED_HASH fatals on HTTP errors before STATUS can be inspected, so a single GitHub releases blip aborts configure (seen on scheduled Fuzz run 42472687801). Download to a temp file, verify SHA256 manually, retry with bounded backoff, and only then promote to the include path. Add cmake -P coverage for the final-failure and success paths.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #53 +/- ##
=======================================
Coverage 89.77% 89.77%
=======================================
Files 125 125
Lines 27317 27317
=======================================
Hits 24523 24523
Misses 2794 2794 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Keep only the cmake/CPM.cmake download-retry fix in this change set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scheduled Fuzz run 42472687801 failed during Build fakelua + fuzz_bridge because
cmake/CPM.cmakeaborted on the firstfile(DOWNLOAD)of CPM 0.38.7 from GitHub Releases (HTTP response code said error). The siblingfuzz_differentialjob on the same SHA succeeded, and the same commit had already passed Fuzz on push (#153) — this was a transient CDN/network flake, not a fuzz crash.CMake's
EXPECTED_HASHonfile(DOWNLOAD)fatals on HTTP failure beforeSTATUScan be inspected, so retries were impossible with the previous bootstrap.Changes
cmake/CPM.cmakeonly: download to a.downloadtemp file, verify SHA256 manually, retry up to 5 times with short backoff, only then promote to the final include path; skip download when a correct cached file already exists; clearFATAL_ERRORdiagnostics on exhaustion.Validation
masterwith-DBUILD_FUZZ=ONused the new bootstrap (CPM SHA256 matched) andmake fuzz_bridgesucceeded.Notes