Repository navigation
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 447 files with indirect coverage changes @@ Coverage Diff @@
## main #22224 +/- ##
==========================================
+ Coverage 69.74% 72.99% +3.25%
==========================================
Files 449 448 -1
Lines 38207 31821 -6386
==========================================
- Hits 26646 23228 -3418
+ Misses 10133 8590 -1543
+ Partials 1428 3 -1425 Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
cc. @fuweid, you partially reviewed this in my manual dependency update for this week. Can we discuss it here? I've been using this script when I need to fix I'm also aiming to automate dependency version bumps, and this is a prerequisite. Thanks! |
fuweid
left a comment
fuweid
left a comment
There was a problem hiding this comment.
Just left comment to add dep for fix-dep.
| PASSES="dep" ./scripts/test.sh | ||
|
|
||
| .PHONY: fix-dep | ||
| fix-dep: |
There was a problem hiding this comment.
| fix-dep: | |
| fix-dep: fix-mod-tidy |
There was a problem hiding this comment.
Good point. I'll also swap them in the fix target to make it explicit.
| # shellcheck disable=SC2317 # invoked indirectly via run_for_workspace_modules | ||
| function dump_module_deps { | ||
| local mod_dir | ||
| mod_dir=$(realpath --relative-to="${ETCD_ROOT_DIR}" .) |
There was a problem hiding this comment.
I don't use macos to update the deps. so --relative-to works to me.
There was a problem hiding this comment.
I don't either, but I try to test these scripts in MacOS, too :)
Signed-off-by: Ivan Valdes <ivan@vald.es>
|
@ivanvc: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This branch has not been deployed
2 participants
This PR implements a
fix-depMakefiletarget that ensures dependencies across the repository match the same (latest defined) version.