Repository navigation
Conversation
Member
|
+cc @ellnix for review |
Contributor
Author
|
@IsaacG I've already requested a review from ellnix. You can leave it to me to ping reviewers on my own PRs, when I get impatient myself. It's fine to poke at stale PRs, but this is only a week old. |
The mise task "update-all-templated-exercise" (sic) prints an error for these two exercises, because confliglet complains they don't exist. This is because they are marked as deprecated config.json. Given that the exercises are deprecated, we won't need the templates anymore to keep the tests up to date. Also, their successor exercises bottle-song and flower-field have very similar test templates. This is somewhat of a preparation for a migration to tera v2. When doing that, it will be nice to be able to confirm all the tests are generated the same way without spurious error messages.
senekor
force-pushed
the
senekor/nntpptxznrum
branch
from
November 21, 2026 14:55
d1762ee to
525e4ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mise task "update-all-templated-exercise" (sic) prints an error for
these two exercises, because confliglet complains they don't exist. This
is because they are marked as deprecated config.json. Given that the
exercises are deprecated, we won't need the templates anymore to keep
the tests up to date. Also, their successor exercises bottle-song and
flower-field have very similar test templates.
This is somewhat of a preparation for a migration to tera v2. When doing
that, it will be nice to be able to confirm all the tests are generated
the same way without spurious error messages.