Skip to content

To stable/linux-6.8.y: tcp/ipv6: re-resolve route after binding ephemeral source port in tcp_v6_connect() #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeffallen wants to merge 1 commit into
base: pr-1
Choose a base branch
from
Open

To stable/linux-6.8.y: tcp/ipv6: re-resolve route after binding ephemeral source port in tcp_v6_connect() #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions net/ipv6/tcp_ipv6.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,28 @@ static int tcp_v6_connect(struct sock *sk, struct sockaddr *uaddr,

sk_set_txhash(sk);

/* The route was resolved before fl6 was complete: the source address
* was unselected (::) and the source port unbound (0). Both are now
* final -- the earlier lookup selected the source (written back to
* fl6.saddr) and inet6_hash_connect() just bound the port. The IPv6
* multipath hash uses the source port (policy=1) or the source
* address (policy=0), so the next hop picked from the incomplete
* tuple may differ from the connection's real one, and the flow would
* migrate on dst invalidation. Re-resolve with the bound port -- as
* tcp_v4_connect() does via ip_route_newports() -- to pin the flow to
* the correct path. Only repeat the lookup if the port changed.
*/
if (fl6.fl6_sport != inet->inet_sport) {
fl6.fl6_sport = inet->inet_sport;
security_sk_classify_flow(sk, flowi6_to_flowi_common(&fl6));
dst = ip6_dst_lookup_flow(net, sk, &fl6, final_p);
if (IS_ERR(dst)) {
err = PTR_ERR(dst);
goto late_failure;
}
ip6_dst_store(sk, dst, NULL, NULL);
}

if (likely(!tp->repair)) {
union tcp_seq_and_ts_off st;

Expand Down