externpro 26.01.5-24-g67ba29e sync - #5
Merged
Merged
Conversation
- Update minimum CMake version from 3.31 to 4.3
- Remove XP_NAMESPACE and xproinc.cmake inclusion (now part of CMakePresets)
- Set CMAKE_INSTALL_CMAKEDIR if not defined (set by xpExternPackage)
- Make xpExternPackage conditional 'if(COMMAND' and move to end of CMakeLists.txt
- Add DEFAULT_TARGETS git2 to xpExternPackage
- xpExternPackage: infer dependencies (libssh2, zlib)
- Package name and Target Namespace now match
- Add CMAKE_EXPERIMENTAL_GENERATE_SBOM in presets
- Change crypto target from xpro::crypto to openssl::crypto
- Define ZLIB_LIBRARIES if not defined (found via cps instead of cmake script)
- with TODO to remove when externpro/zlib has new release with usext.cmake updates
- Reduce changes from upstream (spacing mods to keeps lines unchanged in diff to upstream)
- Normalize cmake command casing to lowercase
- Use bracket-quoted strings for LIBGIT2_FILENAME to fix editor syntax highlighting
- Fix install EXPORT to use NAMESPACE ${CMAKE_PROJECT_NAME}:: instead of ${nameSpace}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update externpro submodule to
26.01.5-24-g67ba29eChanges
.devcontainerto externpro26.01.5-24-g67ba29e0ac4bac86f2f25110dcf941fb94820bd79c061ec67ba29e63e008035d449ef51eeb0e953dacddf54.github/release-tag.json(tag:xpv1.3.0.4)xprodeps.mdxprodeps.svgWorkflow Update Report
CMakePresets.json
Auto-fix: replaced
.devcontainer/cmake/presets/xpWindowsVs2022.jsoninclude and stagedCMakePresets.jsonCMakePresets.json review needed
This PR was created automatically by GitHub Actions