Repository navigation
Harden Cloudflare Worker origin checks - #10
Merged
Merged
Conversation
- reject requests from unknown origins and requests without Origin (403) - keep ALLOWED_ORIGIN=* as an explicit public-proxy opt-in - add unit tests for origin checks, preflight, paths and proxying - update docs and SECURITY.md; version 3.3.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ALLOWED_ORIGIN, and requests without anOriginheader, with 403 instead of proxying them. A deployed worker can no longer be used as an open Telegram proxy by non-browser clients.ALLOWED_ORIGIN="*"remains an explicit opt-in for a deliberately public proxy.tests/proxy.test.mjs: origin rejection, preflight, allowed POST, file GET, path/method validation, wildcard and multiple origins.Testing
npm test— 48/48 pass (8 new tests).npm run build— 25 pages.The worker itself is not deployed by GitHub Pages; this changes the bundled file users paste into Cloudflare.