Repository navigation
Lazy-load tab editors and extend Bot API drift checks - #11
Merged
Merged
Conversation
- import tab controllers only on first activation; the landing page ships less JS - assert in e2e that tabs/* are not requested before connect - check InputProfilePhoto subtypes; the weekly watch also flags a stale spec source - bump version to 3.4.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Performance: lazy tab controllers
import()only when a tab is opened; the landing page no longer downloads the whole editor module graph./assets/js/tabs/request happens before connecting.alwaysReload; controllerinit()runs once,load()runs per open/refresh.Bot API drift
InputProfilePhotosubtypes (Static,Animated), so a new photo type cannot be missed silently.bot-api-updateissue when the spec source looks stale, not only when fields differ. The issue title/body distinguishes real drift from a stale source.Release
Testing
npm test— 48/48 pass.npm run build— 25 pages.node scripts/check-bot-api.mjs— Up to date (spec 10.4).No changes to secrets, remote URLs, or deploy keys. Git remains on the
github-tbmSSH deploy key.