Repository navigation
Quality pass: Bot API drift v2, accessibility, i18n and CI (3.3.0) - #9
Merged
Merged
Conversation
- compare parameters of every method the tool calls, not only setWebhook - check WebhookInfo, BotCommand and MenuButton fields - flag used methods that have no parameter expectations - warn when the spec release date is stale - cover the new checks with synthetic-spec tests and update docs
- move focus to the active tab after connecting - link validation errors to their field with aria-describedby - expose the theme toggle state with aria-pressed - give radio groups accessible names via visible headings - remove the nested toast live region (each toast has its own role) - assert focus, error linkage, theme state and group names in the e2e test
- add tp() with Intl.PluralRules and plural forms for pending updates and saved commands - suggest a localized version on the English root page (banner, no redirect) - test plural completeness and flag untranslated long strings - cover the language suggestion and its persistence in the e2e test
- Playwright 1.65.1 with a browser cache; e2e is back on ubuntu-latest - Lighthouse performance and SEO thresholds are now errors - document METHOD_PARAMS in the Bot API watch issue text - CHANGELOG and package version 3.3.0
The first PR run scored 0.83 on a shared runner while local runs are 100. Performance is noisy on GitHub runners, so keep it a warning at 0.85 and leave SEO as an error at 0.95.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quality pass: Bot API drift v2, accessibility, i18n and CI (3.3.0)
Ветка:
chore/quality-pass(5 коммитов отmain/c9615a1), версия 3.3.0. PR: #9.Что сделано
A. Bot API drift v2 (
8554685)scripts/check-bot-api.mjsсравнивает параметры всех методов, которые вызывает приложение, а не толькоsetWebhook.WebhookInfo,BotCommandи типовMenuButton— новые поля больше не теряются молча.METHOD_PARAMS, теперь попадает в отчёт.release_dateдаёт предупреждение (не «up to date» по умолчанию).CLAUDE.md, README и текст issue в Bot API watch обновлены.B. Доступность (
3e216b1)aria-describedby;role="alert"остаётся для первого объявления.aria-pressed.role="radiogroup"получили имена через видимые заголовки/legend.role="status"/alert.C. i18n (
9387f42)tp()наIntl.PluralRules;webhook.dropConfirmиcommands.savedпереведены на формыone/few/many/otherво всех пяти локалях. Убраны конструкции(s),(es),(ões).navigator.languages(без редиректа, выбор запоминается).allowed_updates,Telegram Business).ru-RU, ссылку и сохранение dismiss после reload.D. Toolchain и релиз (
075c742, фикс7ba9524)ubuntu-latest; добавлен кэш браузеров (actions/cache).error; performance оставленwarn≥ 85 — на GitHub runner'е он дал 0.83 (шум), локально 100; accessibility ≥ 95 и best practices ≥ 90 без изменений.CHANGELOG.md3.3.0,package.json3.3.0.Проверки
npm test— 40/40 pass, 0 fail.npm run build— 25 страниц, футерBot API 10.4 · v3.3.0.node scripts/check-bot-api.mjs— Up to date (spec 10.4, 09.11.2026).node scripts/screenshots.mjs --no-shots— passed локально и в CI (ubuntu-latest, Playwright 1.65.1, 32s).warn≥ 85, SEO —error≥ 95.scripts/screenshots.mjs/tests/validators.test.mjs.Заметки для ревью
e2eнаubuntu-latest+ Playwright 1.65.1 прошёл в CI; performance на runner'е 0.83, поэтому оставлен warning.github-tbm); вmainничего не пушилось.TBM Quality Pass; при необходимости можно переписать наf1devbin.