Repository navigation
Fix convert_size_bytes_to_string returning "1024 <unit>" after rounding - #200
Open
Shaisolaris wants to merge 1 commit into
Open
Shaisolaris wants to merge 1 commit into
Shaisolaris wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #200 +/- ##
=======================================
Coverage 98.52% 98.52%
=======================================
Files 13 13
Lines 812 815 +3
=======================================
+ Hits 800 803 +3
Misses 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
convert_size_bytes_to_stringpicks the unit before rounding, so values just below a unit boundary round up to 1024 of the smaller unit instead of moving to the next one:This happens for any size whose rounded value reaches 1024 (for example
get_file_size_formattedon a file of 1048575 bytes). After the unit loop, the value is now rounded with the same precision used for display, and if that reaches 1024 it is moved to the next unit. Sizes that do not round up to 1024 (such as 1073217536 -> "1023.50 MB") and the existing cases are unchanged, including sizes beyond YB.Related issue
None that I could find.
Checklist before requesting a review
Three cases were added to
test_convert_size_bytes_to_string; the two boundary cases fail on main and pass with the change.pytest testsgives 308 passed locally, andruff check,ruff format --checkandmypy srcare clean. I left CHANGELOG.md alone since it looks like you write it at release time.