Repository navigation
fix: preserve directory index root priority when wildcard is false - #618
Merged
Tony133 merged 3 commits intoNov 13, 2026
Merged
Conversation
Signed-off-by: Talha Shafeeq <talha.shafeeq.ts@gmail.com>
Puppo
reviewed
Nov 2, 2026
Signed-off-by: Talha Shafeeq <talha.shafeeq.ts@gmail.com>
Puppo
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #617
Description
When
wildcard: falseand multiplerootdirectories are configured,indexDirstracks the directory path and the corresponding root to serve directory index routes.However, in
index.js:The condition checked
!indexDirs.has(key)against the basename instead of checking against the directory path (path.posix.dirname(route)). Because the basename string was not the Map key ofindexDirs, subsequent lower-priority roots with index files would overwrite higher-priority roots inindexDirs.This PR:
!indexDirs.has(dir)wheredir = path.posix.dirname(route).wildcard: false.