Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
[Medium impact] This PR appears safe to merge.
|
With
decodeEntities: false, the tokenizer skips to the closing quote of an attribute value. With the defaultdecodeEntities: true, each character of the value goes through theparseloop. Now this path also skips, to the next quote or&. The output does not change.parseDocumenton the builtdist:<table>page, 248 KB<a href="…">with a 50,000-character valueI used 16 interleaved rounds and a Mann-Whitney test (Apple M5, Node 22.23.1 and 20.20.2). I did not measure other engines.
Slowdowns, in 57 benchmarks:
This PR does not change
fastForwardTo, so it does not overlap with #2525.Checks:
npm testpasses on Node 22, andvitestpasses on Node 20.Summary by CodeRabbit