Repository navigation
Vulkan resolve, queues and swapchain growth; follow eye textures to a new device - #77
Open
feimos-dev wants to merge 4 commits into
Open
feimos-dev wants to merge 4 commits into
feimos-dev wants to merge 4 commits into
Conversation
feimos-dev
marked this pull request as ready for review
November 20, 2026 23:32
…esolution, games that change device
feimos-dev
force-pushed
the
compositor-resolve-devices
branch
from
November 21, 2026 00:19
6437005 to
09dcb52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per-API compositor changes and following the game's device.
Vulkan compositor
gfx-vk-boundsexpectations change to match: the image sizes change, the rects are the same.Following a device change
When a D3D11 or D3D12 eye texture is on another device than the session's, the session is made again on the new device through the existing first-time path. The checks that can be made before the old session goes down come first; then, under the session lock, a temporary device is made to fall back on, both eyes' views are cleared (one already stored this frame names the old session's swapchain), and the session moves.
Checked on Linux
scripts/ci/build-linux.sh --tests x64, the stand-in runtime ctest,scripts/ci/conformance-linux.sh x64andabort_sites.py --checkall pass.Checked on a GPU
On Windows with an NVIDIA GPU, against the stand-in runtime, with new conformance cases (in CI; the Vulkan ones skip there, as CI has no Vulkan driver). The Vulkan cases also ran with the Khronos validation layer on, which reported nothing.
gfx-vk-odd, underscripts/gfx_vk_odd.json, whose runtime has single-sampled swapchains only): resolved, then shown upside down. 4x MSAA with full bounds is resolved as it is, and 4x MSAA BGRA8 is resolved and then converted into RGBA8 (gfx-vk-msaa-formats).gfx-vk-odd"other queue"): frames show.gfx-vk-dynamic-resolution, textures of 800, 640, 720 and 960 a side): the swapchain stays 800 x 800 for the first three and grows only for 960.gfx-d3d11-new-device): the session is made again on the new device, and its frames show. Vulkan (gfx-vk-new-device): the new device's frames are refused, as before.scripts/gfx_new_device_refused.json): the frames are left out (InvalidTexture) and the game isn't told to quit.gfx-d3d12-new-devicemakes its second device on WARP, since D3D12 gives one device per adapter; the runtime refuses that adapter, and the game carries on the same way (TextureIsOnWrongDevice). With WARP the only adapter, as on CI, the D3D12 case is skipped.gfx-d3d11-eyes-two-devices): the session follows three times, then the eye on the other device is left out; no frame names a swapchain of a session that's gone, and the game isn't told to quit.The stand-in runtime's script takes
max_swapchain_samplesfor these cases. A D3D12 move that the runtime accepts needs two adapters the runtime takes, which wasn't available.Not in this change