Skip to content

ci: run required checks on every pull request - #16

Merged
sidey79 merged 7 commits into
mainfrom
ci/required-checks-without-path-filter
Nov 10, 2026
Merged

sidey79 merged 7 commits into
mainfrom
ci/required-checks-without-path-filter

Conversation

@sidey79

@sidey79 sidey79 commented Nov 8, 2026

Copy link
Copy Markdown
Collaborator

Problem

Branch protection (ruleset `default`) requires the checks `Perl 5.28`, `Perl 5.32`, `Perl 5.38` and `perlcritic`. Both workflows only run on `pull_request` when files under `FHEM/`, `lib/` etc. change. A PR that only touches e.g. `renovate.json` (#15) never gets these checks, so it stays BLOCKED and Renovate automerge cannot complete.

Change

  • `fhem_test.yml`: removed the `paths:` filter from `pull_request`. `push` keeps its filter.
  • `perlCritic.yml`: removed the `paths:` filter from `pull_request`.

Check names and the required-check configuration are unchanged, so no ruleset change is needed and code PRs still run the full matrix and perlcritic.

Trade-off

Every PR now runs the Perl matrix and perlcritic, including docs- or config-only PRs. This costs CI minutes but keeps the required checks reporting.

Verification

  • Checks on this PR run the new workflow definitions (the workflow file from the PR head).
  • Not yet verified: PR chore(renovate): automerge patch updates #15 itself. It needs this change in its head or on main, and then a new run.

codex added 7 commits November 8, 2026 12:49
The Perl test matrix and the perlcritic check were limited by paths
filters on pull_request. Branch protection requires these checks, so
PRs that only touch other files (e.g. renovate.json) never got a
result and stayed BLOCKED.

Remove the pull_request path filters so the required checks always
report. Push triggers are unchanged.
Task::PerlCriticAllPolicies pulls in the ObjectPad policy, which needs
Perl::Critic::Policy::Modules::RequireExplicitPackage >= 1.134. cpanm
resolved an older 1.132 through the task and bailed out, so the job
failed before linting.

Install the module explicitly first; no policies are dropped.
Task::PerlCriticAllPolicies pulls in Perl::Critic::Grape, which cpanm
does not treat as installed after the bundle run, so the job bails out
before linting. Install Grape explicitly first; no policies are dropped.
Same fix as fhem/mod_RSL#141.
Installing Grape first let cpanm pull an older Perl::Critic (1.132)
through its dependencies, which the policy bundle then rejected. Install
Perl::Critic first, then Grape, then the task. No policies are dropped.
v1.0.1 stores the ASCII-armored debian.fhem.de key as .key, which the
current apt rejects, so the Perl matrix fails before any test runs.
v1.0.2 stores it as .asc.
@sidey79
sidey79 merged commit e0aa28e into main Nov 10, 2026
5 of 8 checks passed
@sidey79
sidey79 deleted the ci/required-checks-without-path-filter branch November 10, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants