Repository navigation
ci: run required checks on every pull request - #16
Merged
Merged
Conversation
The Perl test matrix and the perlcritic check were limited by paths filters on pull_request. Branch protection requires these checks, so PRs that only touch other files (e.g. renovate.json) never got a result and stayed BLOCKED. Remove the pull_request path filters so the required checks always report. Push triggers are unchanged.
Task::PerlCriticAllPolicies pulls in the ObjectPad policy, which needs Perl::Critic::Policy::Modules::RequireExplicitPackage >= 1.134. cpanm resolved an older 1.132 through the task and bailed out, so the job failed before linting. Install the module explicitly first; no policies are dropped.
…icy task" This reverts commit 695f11f.
Task::PerlCriticAllPolicies pulls in Perl::Critic::Grape, which cpanm does not treat as installed after the bundle run, so the job bails out before linting. Install Grape explicitly first; no policies are dropped. Same fix as fhem/mod_RSL#141.
Installing Grape first let cpanm pull an older Perl::Critic (1.132) through its dependencies, which the policy bundle then rejected. Install Perl::Critic first, then Grape, then the task. No policies are dropped.
v1.0.1 stores the ASCII-armored debian.fhem.de key as .key, which the current apt rejects, so the Perl matrix fails before any test runs. v1.0.2 stores it as .asc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Branch protection (ruleset `default`) requires the checks `Perl 5.28`, `Perl 5.32`, `Perl 5.38` and `perlcritic`. Both workflows only run on `pull_request` when files under `FHEM/`, `lib/` etc. change. A PR that only touches e.g. `renovate.json` (#15) never gets these checks, so it stays BLOCKED and Renovate automerge cannot complete.
Change
Check names and the required-check configuration are unchanged, so no ruleset change is needed and code PRs still run the full matrix and perlcritic.
Trade-off
Every PR now runs the Perl matrix and perlcritic, including docs- or config-only PRs. This costs CI minutes but keeps the required checks reporting.
Verification