[macastelaz]

Description

Updates HttpUtils.EncodeQueryParams to percent-encode query parameter keys and string values using Uri.EscapeDataString, ensuring special characters (such as +, =, &, and #) in query parameters like pageToken are properly encoded in outgoing HTTP requests.

Testing

• Added unit tests in HttpUtilsTest covering query parameter encoding.
• Updated and added unit tests in TenantManagerTest, OidcProviderConfigTest, SamlProviderConfigTest, and FirebaseUserManagerTest.

[gemini-code-assist]

Code Review

This pull request updates the HttpUtils.EncodeQueryParams method to properly escape query parameter keys and values using Uri.EscapeDataString. It also includes corresponding updates to various test files to reflect the new URL-encoded format for tokens and masks. I have reviewed the changes and suggest using CultureInfo.InvariantCulture when converting values to strings to ensure consistent formatting across different locales, as the current implementation relies on the thread's culture.

[gemini-code-assist]

Using kvp.Value?.ToString() formats the value using the current thread's culture. If a query parameter value is a culture-sensitive type (such as a floating-point number or a date), it could be formatted differently depending on the machine's locale (e.g., using a comma , instead of a dot . as a decimal separator). This can lead to API request failures on servers expecting invariant culture formatting.

To ensure consistent and culture-insensitive formatting, use Convert.ToString(kvp.Value, CultureInfo.InvariantCulture).

                    .Select(kvp => $"{Uri.EscapeDataString(kvp.Key)}={Uri.EscapeDataString(Convert.ToString(kvp.Value, System.Globalization.CultureInfo.InvariantCulture))}");

[lahirumaramba]

Thanks! Overall LGTM! Added a couple of minor comments.

[lahirumaramba]

super nit: This line is a bit long (146 chars). Can we split the key/value encoding across lines to make it easier to read?

Suggested change

	.Select(kvp => $"{Uri.EscapeDataString(kvp.Key)}={Uri.EscapeDataString(Convert.ToString(kvp.Value, CultureInfo.InvariantCulture))}");
	.Select(kvp =>
	{
	var key = Uri.EscapeDataString(kvp.Key);
	var value = Uri.EscapeDataString(
	Convert.ToString(kvp.Value, CultureInfo.InvariantCulture));
	return $"{key}={value}";
	});

[macastelaz]

Done, split across lines.