Repository navigation
lint: line-length - #849
Conversation
Agent-Team: linux Worker: codex
Resolves the lint.zig conflict with the changelog-words rule. Agent-Team: windows Worker: claude
Keeps the wrapped Rule enum and adds main's anytype-reason rule. Agent-Team: linux Worker: claude Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Agent-Team: linux Worker: claude Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Agent-Team: linux Worker: codex
Agent-Team: linux Worker: codex
Takes main's scripts/ (landed by #837), so the PR shows build.zig alone. Agent-Team: linux Worker: claude
Agent-Team: linux Worker: claude
Agent-Team: linux Worker: claude
Agent-Team: linux Worker: codex
Agent-Team: linux Worker: codex
PM note: how this PR will be handledWhat it is for: lint: line-length Rules that apply: touches build scripts. Things to watch (checked by rule):
What happens next:
A living status comment below is kept current. Nothing here is a merge decision. |
Where this PR standsStage: In review What the PM needs before approving (ticks as it is met; the full CI runs only at the end, after the reviews are clean):
Rules that apply: touches build scripts. Reviews at the current commit (
2 earlier reviews are for older commits and will be redone. Latest fixes comment: https://github.com/fizzyedit/work/issues/355#issuecomment-6409359025 (0 findings answered) Updated 2026-10-26 06:57 UTC by the PM. This comment is edited in place. |
|
PM: this branch is based before #848 merged (04:38Z), which already swept build.zig and the build/ helpers, so it now conflicts with main and its 1025-line diff is mostly #848's work again. Rebase on main and keep only what is left (build/app.zig, the rest of build.zig, scripts/lint.zig: about 530 lines, under the 800 cap; no split needed). Mark it ready after the rebase and I triage it then (part of work#141). Reviews at 6dbe77a will be stale once it is rebased. |
Agent-Team: linux Worker: claude
Agent-Team: linux Worker: claude
Part of fizzyedit/work#358 ## Goal Line-length sweep (work#141) for sdk/remote and sdk/tape: wrap lines over 120 code / 100 comment columns. ## What changed and why Only line breaks in 14 files under sdk/remote and sdk/tape (about 530 changed lines, under the cap). Main is merged in, so fizzyedit#849's build.zig, build/app.zig and scripts/lint.zig no longer show in the diff. The SDK shape fingerprint did not move (wraps only): `scripts/zb build test-sdk-version` passes; the sdk label stays. ## How it was verified check-fmt.sh ok; zb build test-sdk-version 35/35, test 181/181, test-integration 94/94 steps succeeded. Wraps only, so no new test; the existing sdk/remote socket tests pass. ## Not done / follow-ups The final lint rule enforcement is deferred by the plan. <!-- agent-finish: generated below --> <details><summary>Changes (14 files, +441/-93)</summary> ```text sdk/remote/Client.zig | 77 ++++++++++++++++++++++++++++++++++-------- sdk/remote/Connection.zig | 36 ++++++++++++++++---- sdk/remote/capi.zig | 24 ++++++++++--- sdk/remote/fake_fizzy.zig | 35 ++++++++++++++++--- sdk/remote/message.zig | 24 +++++++++++-- sdk/remote/root.zig | 3 +- sdk/remote/tests.zig | 44 ++++++++++++++++++++---- sdk/tape/Script.zig | 31 +++++++++++++---- sdk/tape/Sequencer.zig | 33 +++++++++++++----- sdk/tape/Tape.zig | 85 ++++++++++++++++++++++++++++++++++++++--------- sdk/tape/binary.zig | 85 ++++++++++++++++++++++++++++++++++++++--------- sdk/tape/events.zig | 5 ++- sdk/tape/key.zig | 10 +++++- sdk/tape/ring.zig | 42 +++++++++++++++++++---- 14 files changed, 441 insertions(+), 93 deletions(-) ``` </details> <details><summary>Gates: 6 of 6 passed</summary> ### `scripts/check-fmt.sh` (exit 0) ```text check-fmt: listing tracked files check-fmt: checking 535 files ``` ### `scripts/zb build --summary all` (exit 0) ```text ... (earlier output omitted) | +- compile lib tree-sitter debug native (reused) | +- compile lib freetype debug native (reused) | +- compile lib tree-sitter debug native (reused) | +- options (reused) | +- options (reused) | +- translate-c dvui-c cached | | +- compile exe translate-c debug native (+21 more reused dependencies) | +- options cached | +- options cached +- install text cached | +- compile lib text debug native cached 11ms MaxRSS:40M | +- WriteFile plugin_root.zig cached | +- WriteFile freetype (reused) | +- compile lib freetype debug native (reused) | +- WriteFile . (reused) | +- compile lib tree-sitter debug native (reused) | +- compile lib freetype debug native (reused) | +- compile lib tree-sitter debug native (reused) | +- options (reused) | +- translate-c dvui-c (+1 more reused dependencies) | +- options (reused) | +- options (reused) +- install markdown cached | +- compile lib markdown debug native cached 12ms MaxRSS:40M | +- WriteFile plugin_root.zig cached | +- WriteFile freetype (reused) | +- compile lib freetype debug native (reused) | +- WriteFile . (reused) | +- compile lib tree-sitter debug native (reused) | +- compile lib freetype debug native (reused) | +- compile lib tree-sitter debug native (reused) | +- options (reused) | +- translate-c dvui-c (+1 more reused dependencies) | +- options (reused) | +- options (reused) | +- translate-c (reused) +- install image cached +- compile lib image debug native cached 12ms MaxRSS:40M +- WriteFile plugin_root.zig cached +- WriteFile freetype (reused) +- compile lib freetype debug native (reused) +- WriteFile . (reused) +- compile lib tree-sitter debug native (reused) +- compile lib freetype debug native (reused) +- compile lib tree-sitter debug native (reused) +- options (reused) +- translate-c dvui-c (+1 more reused dependencies) +- options (reused) +- options (reused) ``` ### `scripts/zb build test --summary all` (exit 0) ```text ... (earlier output omitted) +- WriteFile freetype cached +- compile lib freetype debug native cached 12ms MaxRSS:39M +- WriteFile . cached +- compile lib tree-sitter debug native cached 10ms MaxRSS:38M +- compile lib freetype debug native (reused) +- compile lib tree-sitter debug native (reused) +- translate-c dvui-c cached | +- compile exe translate-c debug native cached 6ms MaxRSS:39M | +- options cached | +- options cached | +- options cached | +- run exe generate-def (aarch64.zig) cached | | +- compile exe generate-def debug native cached 4ms MaxRSS:36M | +- run exe generate-def (amdgcn.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (arm.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (bpf.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (common.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (hexagon.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (loongarch.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (mips.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (neon.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (nvptx.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (powerpc.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (riscv.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (s390x.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (ve.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (wasm.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (x86_64.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (x86.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (xcore.zig) cached | +- compile exe generate-def debug native (reused) +- options cached +- options cached ``` ### `scripts/zb build test-integration --summary all` (exit 0) ```text ... (earlier output omitted) | +- options (reused) | +- options (reused) +- run test fizzy-glass-tests cached | +- compile test fizzy-glass-tests debug native cached 12ms MaxRSS:39M | +- WriteFile freetype (reused) | +- compile lib freetype debug native (reused) | +- WriteFile . (reused) | +- compile lib tree-sitter debug native (reused) | +- compile lib freetype debug native (reused) | +- compile lib tree-sitter debug native (reused) | +- translate-c dvui-c (+1 more reused dependencies) | +- options (reused) | +- options (reused) +- run test fizzy-plugin-loader-tests cached | +- compile test fizzy-plugin-loader-tests debug native cached 13ms MaxRSS:36M | +- WriteFile freetype (reused) | +- compile lib freetype debug native (reused) | +- WriteFile . (reused) | +- compile lib tree-sitter debug native (reused) | +- compile lib freetype debug native (reused) | +- compile lib tree-sitter debug native (reused) | +- translate-c dvui-c (+1 more reused dependencies) | +- options (reused) | +- options (reused) +- run test fizzy-text-plugin-tests cached | +- compile test fizzy-text-plugin-tests debug native cached 13ms MaxRSS:40M | +- options (reused) | +- WriteFile freetype (reused) | +- compile lib freetype debug native (reused) | +- WriteFile . (reused) | +- compile lib tree-sitter debug native (reused) | +- compile lib freetype debug native (reused) | +- compile lib tree-sitter debug native (reused) | +- translate-c dvui-c (+1 more reused dependencies) | +- options (reused) | +- options (reused) +- run test fizzy-workbench-plugin-tests cached +- compile test fizzy-workbench-plugin-tests debug native cached 12ms MaxRSS:40M +- options (reused) +- options (reused) +- WriteFile freetype (reused) +- compile lib freetype debug native (reused) +- WriteFile . (reused) +- compile lib tree-sitter debug native (reused) +- compile lib freetype debug native (reused) +- compile lib tree-sitter debug native (reused) +- translate-c dvui-c (+1 more reused dependencies) +- options (reused) +- options (reused) ``` ### `scripts/zb build check-web --summary all` (exit 0) ```text ... (earlier output omitted) | | +- run exe generate-def (amdgcn.zig) cached | | | +- compile exe generate-def debug native (reused) | | +- run exe generate-def (arm.zig) cached | | | +- compile exe generate-def debug native (reused) | | +- run exe generate-def (bpf.zig) cached | | | +- compile exe generate-def debug native (reused) | | +- run exe generate-def (common.zig) cached | | | +- compile exe generate-def debug native (reused) | | +- run exe generate-def (hexagon.zig) cached | | | +- compile exe generate-def debug native (reused) | | +- run exe generate-def (loongarch.zig) cached | | | +- compile exe generate-def debug native (reused) | | +- run exe generate-def (mips.zig) cached | | | +- compile exe generate-def debug native (reused) | | +- run exe generate-def (neon.zig) cached | | | +- compile exe generate-def debug native (reused) | | +- run exe generate-def (nvptx.zig) cached | | | +- compile exe generate-def debug native (reused) | | +- run exe generate-def (powerpc.zig) cached | | | +- compile exe generate-def debug native (reused) | | +- run exe generate-def (riscv.zig) cached | | | +- compile exe generate-def debug native (reused) | | +- run exe generate-def (s390x.zig) cached | | | +- compile exe generate-def debug native (reused) | | +- run exe generate-def (ve.zig) cached | | | +- compile exe generate-def debug native (reused) | | +- run exe generate-def (wasm.zig) cached | | | +- compile exe generate-def debug native (reused) | | +- run exe generate-def (x86_64.zig) cached | | | +- compile exe generate-def debug native (reused) | | +- run exe generate-def (x86.zig) cached | | | +- compile exe generate-def debug native (reused) | | +- run exe generate-def (xcore.zig) cached | | +- compile exe generate-def debug native (reused) | +- options cached | +- options cached | +- options cached | +- options cached | +- options cached | +- options cached | +- options cached | +- options cached | +- options cached | +- options cached | +- translate-c cached 3ms MaxRSS:35M +- compile obj rehome-fixture-web debug wasm32-freestanding cached 5ms MaxRSS:40M +- translate-c dvui-c (+1 more reused dependencies) +- options (reused) +- options (reused) ``` ### `scripts/zb build test-sdk-version --summary all` (exit 0) ```text ... (earlier output omitted) +- WriteFile . cached +- compile lib tree-sitter debug native cached 9ms MaxRSS:36M +- compile lib freetype debug native (reused) +- compile lib tree-sitter debug native (reused) +- options cached +- options cached +- translate-c dvui-c cached | +- compile exe translate-c debug native cached 5ms MaxRSS:39M | +- options cached | +- options cached | +- options cached | +- run exe generate-def (aarch64.zig) cached | | +- compile exe generate-def debug native cached 5ms MaxRSS:35M | +- run exe generate-def (amdgcn.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (arm.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (bpf.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (common.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (hexagon.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (loongarch.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (mips.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (neon.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (nvptx.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (powerpc.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (riscv.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (s390x.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (ve.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (wasm.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (x86_64.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (x86.zig) cached | | +- compile exe generate-def debug native (reused) | +- run exe generate-def (xcore.zig) cached | +- compile exe generate-def debug native (reused) +- options cached +- options cached ``` </details> --------- Co-authored-by: fizzy-linux[bot] <346940526+fizzy-linux[bot]@users.noreply.github.com> Co-authored-by: fizzy-windows[bot] <347008912+fizzy-windows[bot]@users.noreply.github.com> Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
Part of fizzyedit/work#356
Goal
Wrap the build files and scripts/lint.zig to the 120-column limit (work#141 line-length ratchet).
What changed and why
Only line breaks in build.zig, build/app.zig and scripts/lint.zig. Main is merged in, so the diff against main is just these three files. The msvc addFail message is back to its original multiline string literal.
How it was verified
check-fmt ok; zb build 84/84, test 181/181, test-integration 94/94 steps succeeded. git diff -w against main shows only wrapping.
Not done / follow-ups
The enforcing lint rule and its test land in the final sweep PR; that rule should allow multiline string literals.
Changes (3 files, +440/-77)
Gates: 6 of 6 passed
scripts/check-fmt.sh(exit 0)scripts/zb build --summary all(exit 0)scripts/zb build test --summary all(exit 0)scripts/zb build test-integration --summary all(exit 0)scripts/zb build check-web --summary all(exit 0)scripts/zb build test-sdk-version --summary all(exit 0)