Repository navigation
app: chrome-option - #865
Conversation
Fizzy's shape reads -Dchrome-sidebar-edge, -Dchrome-panel, -Dchrome-menu-bar and -Dchrome-infobar; the defaults are its own frame. Agent-Team: linux Worker: claude Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
PM note: how this PR will be handledWhat it is for: app: chrome-option Rules that apply: touches build scripts; changes agent rules or guides. Things to watch (checked by rule):
What happens next:
A living status comment below is kept current. Nothing here is a merge decision. |
Where this PR standsStage: Waiting for the maintainer What the PM needs before approving (ticks as it is met; the full CI runs only at the end, after the reviews are clean):
Rules that apply: touches build scripts; changes agent rules or guides. Reviews at the current commit (
4 earlier reviews are for older commits and will be redone. Latest fixes comment: https://github.com/fizzyedit/work/issues/385#issuecomment-6437664789 (18 findings answered) Updated 2026-10-27 10:50 UTC by the PM. This comment is edited in place. |
Chrome.Edge is the build option's own enum, dropping the second enum and the tagName round trip; Editor.init no longer repeats the field default; Chrome.menu_bar and AGENTS.md say macOS keeps its native menu. Agent-Team: linux Worker: claude Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Agent-Team: linux Worker: codex
Part of fizzyedit/work#396
Goal
Answer PR #865's Chrome review findings for fizzyedit/work#396.
What changed and why
Mobile now honors panel=false for both the Panel region and its toggle, even when a plugin provides panel content. Landscape Explorer follows sidebar_edge and Panel takes the opposite edge. Real menu/infobar enabled/disabled layout tests replace forced suppression in the shim. Toggle Explorer's icon follows the configured edge; documentation describes mobile behavior and wraps the macOS caveat.
How it was verified
Headless Linux integration coverage measures actual bounds at portrait/tablet/landscape sizes. Removing bar guards or mobile Panel gating makes the new tests fail; forcing the landscape Explorer left independently fails its bounds assertion. Native build, unit tests, lint, web compilation, SDK fingerprint and test reachability pass. Full integration completes with 246/250 tests passing; four sandbox socket-dependent control tests fail, named in GATES.md.
Not done / follow-ups
Desktop/phone demo-app screenshots require an explicitly authorized window launch under docs/AGENT_WORK.md and remain outstanding. The unverified right-rail one-frame Panel timing concern is declined with rationale in FIXES.md. The harness must commit/publish and post the single FIXES comment using the resulting head; no GitHub or git write actions were performed here.
Changes (105 files, +3921/-5680)
Gates: 6 of 6 passed
scripts/check-fmt.sh(exit 0)scripts/zb build --summary all(exit 0)scripts/zb build test --summary all(exit 0)scripts/zb build test-integration --summary all(exit 0)scripts/zb build check-web --summary all(exit 0)scripts/zb build test-sdk-version --summary all(exit 0)