Skip to content

web: main fails to start: Cannot access 'textInput' before initialization (name clash from the au... - #987

Closed
fizzy-linux[bot] wants to merge 5 commits into
mainfrom
linux/work-633
Closed

web: main fails to start: Cannot access 'textInput' before initialization (name clash from the au...#987
fizzy-linux[bot] wants to merge 5 commits into
mainfrom
linux/work-633

Conversation

@fizzy-linux

@fizzy-linux fizzy-linux Bot commented Oct 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Part of fizzyedit/work#633
Rework: work#801

In plain words

This fixes the duplicate declaration that stops the web checks from starting when this branch is combined with main. The change keeps the existing startup checks intact.

What you will notice

Nothing visible: internal.

How this serves fizzy

Goal: reliable web startup; keeps the web checks able to detect problems before release.

Goal

Address PR #987's latest PM ruling, duplicate workerMessages declaration only (work#801).

What changed and why

Move the existing declaration beside the worker mock, matching origin/main's insertion location. Three-way merging then produces one declaration rather than two. No other source change.

How it was verified

Formatting, lint, native build, unit tests, integration, check-web, SDK-version and all local web suites pass. A three-way file merge reproduces the duplicate SyntaxError without this edit and passes syntax checking with it. See GATES.md for exact results and the additional merged runtime assertion failure.

Not done / follow-ups

Harness must merge current main, commit, push and post FIXES; this sandbox cannot write Git metadata or use the network. The merged embed test reaches a later existing assertion interaction: this branch moves the input to 30px, main expects 20px. No change made outside the duplicate-declaration-only ruling; merged runtime suite is not claimed passing.

Changes (207 files, +1735/-7317) 
 .github/pull_request_template.md         |  54 +---
 .github/workflows/agent-work.yml         |  85 +-----
 CONTRIBUTING.md                          |   8 +-
 android/AGENTS.md                        |  17 --
 android/AndroidManifest.xml              |  20 --
 android/CLAUDE.md                        |   1 -
 android/README.md                        |  56 ----
 android/src/FizzyActivity.java           |   9 -
 android/src/main.zig                     |  77 -----
 app/ActivityFeed.zig                     |   2 +-
 app/App.zig                              | 112 +++----
 app/AppInfo.zig                          |   6 +-
 app/HistoryTransport.zig                 |   8 +-
 app/Liquid.zig                           |   6 +-
 app/Recents.zig                          |   6 +-
 app/RecentsMigration.zig                 |   4 +-
 app/Secrets.zig                          |  12 +-
 app/Tracks.zig                           |   2 +-
 app/automation/Calm.zig                  |  12 +-
 app/automation/Service.zig               |   6 +-
 app/automation/overlay.zig               |  52 ++--
 app/control/Link.zig                     |   4 -
 app/control/Server.zig                   |  17 +-
 app/control/json.zig                     |   6 +-
 app/control/openapi.zig                  |   2 +-
 app/control/routes.zig                   |   2 +-
 app/control/screen_diff.zig              |   4 +-
 app/crash/crash.zig                      |   2 +-
 app/dome.zig                             |  14 +-
 app/dome_rules.zig                       |   2 +-
 app/keymap/Keymap.zig                    |  38 +--
 app/keymap/dvui_adapter.zig              |   4 +-
 app/keymap/zon.zig                       |   8 +-
 app/layout/Chooser.zig                   |  46 +--
 app/layout/Drop.zig                      |  14 +-
 app/layout/Floats.zig                    |  98 +++---
 app/layout/Layout.zig                    | 212 ++++++-------
 app/layout/Picker.zig                    |  48 +--
 app/layout/Rail.zig                      |  18 +-
 app/layout/Region.zig                    | 178 +++++------
 app/layout/Seed.zig                      |   4 +-
 app/layout/Shape.zig                     |   8 +-
 app/layout/SidePane.zig                  |   8 +-
 app/layout/SplitTree.zig                 |   8 +-
 app/layout/State.zig                     |  74 ++---
 app/layout/Tree.zig                      |   2 +-
 app/layout/ViewDrag.zig                  | 364 +++++++++++-----------
 app/layout/float_rules.zig               |  22 +-
 app/layout/place_commands.zig            |   2 +-
 app/mcp_names.zig                        |   6 +-
 app/profile.zig                          |  16 +-
 app/remote/RemoteViewHost.zig            |   2 +-
 app/restart.zig                          |  16 +-
 app/root.zig                             |  32 +-
 app/settings/PluginSettingsPane.zig      |  18 +-
 app/settings/SettingRow.zig              |  16 +-
 app/settings/Settings.zig                |  43 +--
 app/settings/SettingsMigration.zig       |  61 +---
 app/settings/SettingsPluginsZon.zig      |  60 ++--
 app/single_instance/singleton.zig        |   2 +-
 app/single_instance/singleton_native.zig |  20 +-
 app/single_instance/singleton_web.zig    |   2 +-
 app/store/PluginLoader.zig               |  50 +--
 app/store/PluginLoader_web.zig           |  14 +-
 app/store/PluginManager.zig              |  20 +-
 app/store/PluginPage.zig                 |  24 +-
 app/store/PluginStore.zig                | 396 ++++++++++++------------
 app/store/plugin_repo_asset.zig          |   6 +-
 app/store/readme.zig                     |  12 +-
 app/store/registry/compat.zig            |   2 +-
 app/store/registry/registry.zig          |  30 +-
 app/store/registry/store.zig             |  32 +-
 app/store/store_icon.zig                 |   6 +-
 app/store/web_fetch.zig                  |   4 +-
 app/update/auto_update.zig               |  10 +-
 app/update/update_install.zig            |  26 +-
 app/update/update_notify.zig             |  30 +-
 app/view/ViewHost.zig                    |   4 +-
 app/watch/ExecutableWatcher.zig          |   6 +-
 app/watch/FolderWatcher.zig              |  24 +-
 app/watch/SettingsWatcher.zig            |  28 +-
 app/watch/folder_events.zig              |  22 +-
 app/watch/wake.zig                       |   4 +-
 backend/src/SDLBackend.zig               |  12 +-
 backend/src/glass/input_time.zig         |  59 ----
 backend/src/glass/liquid_blob.zig        |   6 +-
 backend/src/glass/root.zig               |   2 -
 backend/src/platform/dialogs.zig         |   2 +-
 backend/src/platform/menu.zig            |   4 +-
 build.zig                                |   3 -
 build/android.zig                        | 113 -------
 build/app.zig                            |  31 +-
 build/web.zig                            |   1 -
 core/FileTable.zig                       |   2 +-
 core/Fling.zig                           |  16 +-
 core/anim.zig                            |   1 -
 core/card_level.zig                      | 202 -------------
 core/core.zig                            |  11 +-
 core/input_time.zig                      |  20 ++
 core/keyboard.zig                        | 108 -------
Gates: 6 of 6 passed

scripts/check-fmt.sh (exit 0)

check-fmt: listing tracked files
check-fmt: checking 569 files

scripts/zb build --summary all (exit 0)

... (earlier output omitted)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- options (reused)
|     +- options (reused)
|     +- translate-c dvui-c cached
|     |  +- compile exe translate-c debug native (+21 more reused dependencies)
|     +- options cached
|     +- options cached
+- install text cached
|  +- compile lib text debug native cached 12ms MaxRSS:37M
|     +- WriteFile plugin_root.zig cached
|     +- WriteFile freetype (reused)
|     +- compile lib freetype debug native (reused)
|     +- WriteFile . (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- options (reused)
|     +- translate-c dvui-c (+1 more reused dependencies)
|     +- options (reused)
|     +- options (reused)
+- install markdown cached
|  +- compile lib markdown debug native cached 13ms MaxRSS:36M
|     +- WriteFile plugin_root.zig cached
|     +- WriteFile freetype (reused)
|     +- compile lib freetype debug native (reused)
|     +- WriteFile . (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- options (reused)
|     +- translate-c dvui-c (+1 more reused dependencies)
|     +- options (reused)
|     +- options (reused)
|     +- translate-c (reused)
+- install image cached
   +- compile lib image debug native cached 12ms MaxRSS:36M
      +- WriteFile plugin_root.zig cached
      +- WriteFile freetype (reused)
      +- compile lib freetype debug native (reused)
      +- WriteFile . (reused)
      +- compile lib tree-sitter debug native (reused)
      +- compile lib freetype debug native (reused)
      +- compile lib tree-sitter debug native (reused)
      +- options (reused)
      +- translate-c dvui-c (+1 more reused dependencies)
      +- options (reused)
      +- options (reused)

scripts/zb build test --summary all (exit 0)

... (earlier output omitted)
      +- WriteFile freetype cached
      +- compile lib freetype debug native cached 11ms MaxRSS:38M
      +- WriteFile . cached
      +- compile lib tree-sitter debug native cached 10ms MaxRSS:35M
      +- compile lib freetype debug native (reused)
      +- compile lib tree-sitter debug native (reused)
      +- translate-c dvui-c cached
      |  +- compile exe translate-c debug native cached 6ms MaxRSS:39M
      |     +- options cached
      |     +- options cached
      |     +- options cached
      |     +- run exe generate-def (aarch64.zig) cached
      |     |  +- compile exe generate-def debug native cached 5ms MaxRSS:39M
      |     +- run exe generate-def (amdgcn.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (arm.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (bpf.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (common.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (hexagon.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (loongarch.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (mips.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (neon.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (nvptx.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (powerpc.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (riscv.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (s390x.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (ve.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (wasm.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (x86_64.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (x86.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (xcore.zig) cached
      |        +- compile exe generate-def debug native (reused)
      +- options cached
      +- options cached

scripts/zb build test-integration --summary all (exit 0)

... (earlier output omitted)
|     +- options (reused)
+- run test fizzy-plugin-loader-tests cached
|  +- compile test fizzy-plugin-loader-tests debug native cached 13ms MaxRSS:39M
|     +- WriteFile freetype (reused)
|     +- compile lib freetype debug native (reused)
|     +- WriteFile . (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- translate-c dvui-c (+1 more reused dependencies)
|     +- options (reused)
|     +- options (reused)
+- run test fizzy-text-plugin-tests cached
|  +- compile test fizzy-text-plugin-tests debug native cached 13ms MaxRSS:39M
|     +- options (reused)
|     +- WriteFile freetype (reused)
|     +- compile lib freetype debug native (reused)
|     +- WriteFile . (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- translate-c dvui-c (+1 more reused dependencies)
|     +- options (reused)
|     +- options (reused)
+- run test fizzy-dashboard-plugin-tests cached
|  +- compile test fizzy-dashboard-plugin-tests debug native cached 13ms MaxRSS:39M
|     +- options (reused)
|     +- WriteFile freetype (reused)
|     +- compile lib freetype debug native (reused)
|     +- WriteFile . (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- translate-c dvui-c (+1 more reused dependencies)
|     +- options (reused)
|     +- options (reused)
+- run test fizzy-workbench-plugin-tests cached
   +- compile test fizzy-workbench-plugin-tests debug native cached 12ms MaxRSS:36M
      +- options (reused)
      +- options (reused)
      +- WriteFile freetype (reused)
      +- compile lib freetype debug native (reused)
      +- WriteFile . (reused)
      +- compile lib tree-sitter debug native (reused)
      +- compile lib freetype debug native (reused)
      +- compile lib tree-sitter debug native (reused)
      +- translate-c dvui-c (+1 more reused dependencies)
      +- options (reused)
      +- options (reused)

scripts/zb build check-web --summary all (exit 0)

... (earlier output omitted)
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (arm.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (bpf.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (common.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (hexagon.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (loongarch.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (mips.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (neon.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (nvptx.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (powerpc.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (riscv.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (s390x.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (ve.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (wasm.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (x86_64.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (x86.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (xcore.zig) cached
|  |        +- compile exe generate-def debug native (reused)
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- translate-c cached 3ms MaxRSS:34M
+- compile obj rehome-fixture-web debug wasm32-freestanding cached 5ms MaxRSS:36M
   +- translate-c dvui-c (+1 more reused dependencies)
   +- options (reused)
   +- options (reused)

scripts/zb build test-sdk-version --summary all (exit 0)

... (earlier output omitted)
   +- WriteFile . cached
   +- compile lib tree-sitter debug native cached 10ms MaxRSS:36M
   +- compile lib freetype debug native (reused)
   +- compile lib tree-sitter debug native (reused)
   +- options cached
   +- options cached
   +- translate-c dvui-c cached
   |  +- compile exe translate-c debug native cached 6ms MaxRSS:39M
   |     +- options cached
   |     +- options cached
   |     +- options cached
   |     +- run exe generate-def (aarch64.zig) cached
   |     |  +- compile exe generate-def debug native cached 5ms MaxRSS:35M
   |     +- run exe generate-def (amdgcn.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (arm.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (bpf.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (common.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (hexagon.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (loongarch.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (mips.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (neon.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (nvptx.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (powerpc.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (riscv.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (s390x.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (ve.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (wasm.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (x86_64.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (x86.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (xcore.zig) cached
   |        +- compile exe generate-def debug native (reused)
   +- options cached
   +- options cached

@fizzy-ops fizzy-ops Bot added the pm:review one assigned reviewer reviews label Oct 28, 2026
@fizzy-ops

fizzy-ops Bot commented Oct 28, 2026

Copy link
Copy Markdown

TRIAGE @2f12172b auto: mechanical rules met (fizzy-* app author, names work#633, 18 non-test lines <= 400, no risky path). Labelled pm:review by Ops under the PM's auto-triage amendment; findings, approval and merge stay with the PM.

@fizzy-pm

fizzy-pm Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

PM note: how this PR will be handled

What it is for: linux: work-633
Issue #633: web: main fails to start: Cannot access 'textInput' before initialization (name clash from the autocorrect filter)

Rules that apply: none special.
Reviews needed: 1, from any other team or kind.
Needs the maintainer's explicit yes before merge: no

Things to watch (checked by rule):

  • the body names its work issue (Part of fizzyedit/work#N)
  • size within 800 lines outside tests and docs (18)
  • a gates section with what was run

What happens next:

  1. Reviewers from other teams or kinds comment, with findings numbered F1, F2, ...
  2. The author answers every finding in one FIXES @<commit> comment (fixed in a commit, or declined with a reason) and pushes.
  3. Reviewers re-review the new commit on their own.
  4. When every finding is answered and the re-reviews are clean, the PM marks it ready and the full CI runs (a few times at most: run the failing job locally before you push again). Only when CI passes does the PM look, and the PM gives the final okay.

A living status comment below is kept current. Nothing here is a merge decision.

@fizzy-pm

fizzy-pm Bot commented Oct 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Where this PR stands

Stage: Author's turn
Next: Author should fix what CI reports (run the failing job locally before you push again)

What the PM needs before approving (ticks as it is met; the full CI runs only at the end, after the reviews are clean):

  • The body names its basis (Part of fizzyedit/work#N or a plan step)
  • Within the size limit: 19 of 800 lines outside tests and docs
  • The body shows which gates the author ran
  • No open findings at this commit
  • Every earlier finding was answered in a FIXES comment (1 answered)
  • Clean reviews at this commit from 1 kind: fizzy-publish (has 1)
  • Marked ready, which starts the full CI (the PM does this the moment the items above are met)
  • The full CI passes at this commit (CI is red)
  • The PM's final okay (pm-approval)

Reviews at the current commit (c2a9f48):

Reviewer Verdict Findings
fizzy-publish clean none

3 earlier reviews are for older commits and will be redone.

Latest fixes comment: https://github.com/fizzyedit/work/issues/669#issuecomment-6524884532 (1 finding answered)

Updated 2026-10-30 14:20 UTC by the PM. This comment is edited in place.

@fizzy-windows fizzy-windows Bot added the reviewing:windows-agy a windows/agy review is running label Oct 28, 2026
@fizzy-macos fizzy-macos Bot added reviewing:macos-claude a macos/claude review is running and removed reviewing:macos-claude a macos/claude review is running labels Oct 28, 2026
@fizzy-pm
fizzy-pm Bot marked this pull request as ready for review October 28, 2026 19:52
@fizzy-windows fizzy-windows Bot added reviewing:windows-agy a windows/agy review is running and removed reviewing:windows-agy a windows/agy review is running labels Oct 28, 2026
@fizzy-macos fizzy-macos Bot added reviewing:macos-agy a macos/agy review is running and removed reviewing:macos-agy a macos/agy review is running labels Oct 28, 2026
@fizzy-pm fizzy-pm Bot removed the pm:review one assigned reviewer reviews label Oct 29, 2026
@fizzy-pm
fizzy-pm Bot added this pull request to the merge queue Oct 29, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 29, 2026
@fizzy-pm
fizzy-pm Bot added this pull request to the merge queue Oct 29, 2026
@fizzy-linux
linux: work-633 (codex)
9148614 
Agent-Team: linux

Worker: codex
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 29, 2026
@fizzy-pm
fizzy-pm Bot added this pull request to the merge queue Oct 29, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 29, 2026
@fizzy-pm fizzy-pm Bot changed the title linux: work-633 web: main fails to start: Cannot access 'textInput' before initialization (name clash from the au... Oct 29, 2026
@fizzy-pm fizzy-pm Bot added pm:review one assigned reviewer reviews reviewer:macos-claude the PM assigned macos/claude to review this PR reviewer:windows-claude the PM assigned windows/claude to review this PR kind:codex agent kind that wrote the PR (new workflow) and removed reviewer:macos-claude the PM assigned macos/claude to review this PR labels Oct 29, 2026
@fizzy-pm
fizzy-pm Bot marked this pull request as draft October 30, 2026 04:59
@fizzy-pm
fizzy-pm Bot marked this pull request as ready for review October 30, 2026 04:59
@fizzy-pm
fizzy-pm Bot marked this pull request as draft October 30, 2026 11:22
@fizzy-pm
fizzy-pm Bot marked this pull request as ready for review October 30, 2026 11:22
@fizzy-pm
fizzy-pm Bot marked this pull request as draft October 30, 2026 11:32
@fizzy-pm
fizzy-pm Bot marked this pull request as ready for review October 30, 2026 11:32
@fizzy-pm
fizzy-pm Bot marked this pull request as draft October 30, 2026 12:29
@fizzy-pm
fizzy-pm Bot marked this pull request as ready for review October 30, 2026 12:29
@fizzy-pm
fizzy-pm Bot marked this pull request as draft October 30, 2026 13:20
@fizzy-pm
fizzy-pm Bot marked this pull request as ready for review October 30, 2026 13:20
@fizzy-pm
fizzy-pm Bot marked this pull request as draft October 30, 2026 13:50
@fizzy-pm
fizzy-pm Bot marked this pull request as ready for review October 30, 2026 13:50
@fizzy-publish
fizzy-publish Bot enabled auto-merge October 30, 2026 13:54
@fizzy-pm fizzy-pm Bot added pm:fixes author fixes the must-fix items and removed pm:review one assigned reviewer reviews labels Oct 30, 2026
@fizzy-linux
linux: work-633 (codex)
c2a9f48 
Agent-Team: linux

Worker: codex
@fizzy-publish

fizzy-publish Bot commented Oct 30, 2026

Copy link
Copy Markdown

Follow-ups:
[
{
"id": "F1",
"severity": "minor",
"file": "web/fizzy.js",
"line": 1036,
"added": false,
"text": "oskCheck sizes the hidden input's height from textInputRect[2] (the width); the rect is [x, y, w, h], so it should use textInputRect[3]. Not part of this change."
}
]

@fizzy-pm

fizzy-pm Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

PM decision after two rounds (hard stop): the rework fixed the first CI error but CI fails again on a different web test ('the input stays above the keyboard'), because main's keyboard handling moved (fizzy#1019). Closing this old branch; work#633 is re-cut fresh against current main (first check whether the startup crash still reproduces: fizzy#970 may already have fixed it).

@fizzy-pm fizzy-pm Bot closed this Oct 30, 2026
auto-merge was automatically disabled October 30, 2026 14:39

Pull request was closed

This branch was previously deployed

1 inactive deployment
bridge — c2a9f485 Deployed Oct 30, 2026 by fizzy-pm[bot] via bridge #3200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

kind:codex agent kind that wrote the PR (new workflow) pm:fixes author fixes the must-fix items reviewer:windows-claude the PM assigned windows/claude to review this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

0 participants