Repository navigation
fix(upgrade): bring extensions to Prettier 3, webpack-cli 7 and @flarum/jest-config 2.1.1 - #70
Merged
Merged
Conversation
…um/jest-config 2.1.1 The upgrade formats an extension's code with Prettier 3, then left the extension on Prettier 2, so its own format-check could disagree. New extensions were scaffolded with Prettier 2 too, while the CLI formats the code it generates with Prettier 3. Both now use the tooling the bundled extensions build with (flarum/framework#5280).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #0000 (follows flarum/framework#5280, which moves the bundled extensions to the same tooling)
Changes proposed in this pull request:
fl upgrade 2.0formats an extension's code with Prettier 3, then left the extension on Prettier 2, so its ownformat-checkcould disagree with the result.fl initalso scaffolded Prettier 2, while the CLI formats the code it generates with Prettier 3. The upgrade and the scaffold now use Prettier ^3.9.10, webpack-cli ^7.2.3 and @flarum/jest-config ^2.1.1, the release that requires flarum-webpack-config ^3.1.0. As before, an extension already asking for a newer version keeps it.Reviewers should focus on:
js/srcpasses Prettier 3's--checkwith Flarum's config.Screenshot
N/A
Necessity
Confirmed
yarn testinjs/). (N/A, CLI.)composer test). (yarn test: 423 tests, Prettier, ESLint and tsc.)