fix: stop MarkerLayer wrap loops on a non-finite camera - #2242
Closed
AzazelSensei wants to merge 1 commit into
Closed
fix: stop MarkerLayer wrap loops on a non-finite camera#2242AzazelSensei wants to merge 1 commit into
AzazelSensei wants to merge 1 commit into
Conversation
fleaflet#2178 only rejects a non-finite Marker.point. A NaN camera still makes Rect.overlaps return true for every world copy, so the wrap loops never stop. Skip the layer when the camera is not finite, skip wrapping a marker whose projected point is not finite, and cap world shifts the same way workAcrossWorlds already does.
Member
|
Thanks for your contribution! The root issue should now be fixed, please ping me if it isn't. And as previously discussed, this is a partial patch which doesn't solve the root issue. That's not to say that this isn't a good idea, as it is defensive against similar bugs in future, but I am not completely happy with the implementation either. So for now, I'm going to close this PR. But please feel free to contribute again in future! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2240
#2178 only rejects a non-finite
Marker.point. A NaN camera still makesRect.overlapsreturn true for every world copy, so the wrap loops never stop.I skip
MarkerLayerwhen the camera isn't finite, and I skip wrapping a marker if its projected point isn't finite either. There's also a 30-shift cap likeworkAcrossWorlds, so a future never-culls bug throws instead of taking the process down.Widget test:
rotate(double.nan), thenpump()has to return.