feat(wallet): add SigmaJS prover - #217
Conversation
🦋 Changeset detectedLatest commit: 4310ceb The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@arobsn @mhrn83 could you please review this submission for issue #110 and confirm the 50 ERG bounty status? The PR is currently mergeable. It adds the SigmaJS prover, transaction and message signing tests, documentation, and a changeset. I am available to address review feedback promptly here in writing. |
|
Local verification update: branch is 0 commits behind master and mergeable. Recursive workspace build passes, exit 0. Lint passes across 218 files and format/import checks pass across 220 files. New SigmaJS prover tests pass 10/10. Targeted V8 coverage for sigmaJsProver.ts is 100% statements, branches, functions, and lines. Full unit run reached 1141/1142; the only failure was the unchanged property test in proveDLogProtocol.spec.ts timing out at 5 seconds under full-suite load. Its immediate isolated rerun passed 8/8 in 3.82 seconds, including the timed-out test in 2.56 seconds. No file involved in that transient timeout is modified by this PR. Ready for review. |
|
Hi @arobsn тАФ following up on the SigmaJS prover submitted for #110. As of September 5, this PR remains open and mergeable, with no maintainer review recorded. Before putting more work into it, could you confirm whether the implementation is still wanted and whether the advertised 50 ERG bounty is still funded? If it is, please identify the remaining acceptance requirements and the payout process following acceptance. A short тАЬstill wanted / no longer neededтАЭ reply would also help us close the loop. No additional scope is assumed. |
Summary
ISigmaProverimplementation to@fleet-sdk/walletValidation
pnpm test:unit— 67 files, 1,142 tests passedpnpm cov:check— 100% statements, functions and lines; new prover has 100% branch coveragepnpm test:lint— passedpnpm -r build— passedpnpm --filter @fleet-sdk/wallet build— passed without warningsCloses #110