You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Modern Nix is pickier about Python dependencies so we need to be more explicit about any vendored packages now
About the source changes specifically:
Extra headers are not included transitively by GCC 14, so we need to be more explicit now
Several changes were made for Doxygen compatibility: e.g., using C = ... was causing Doxygen warnings, and the current build errors on any Doxygen warnings at all. We could potentially work around this differently (e.g., not making warnings a hard error)
For some reason we seem to have lost the num_gpus=2 in the Realm GPU model parallelism test, so I put that back here
Passes local CPU and GPU CI on Sapling.
I should note: this also includes #1659 so you can merge that one separately or as a part of this PR.
I should note: we could potentially expand the deploy tests to sweep a larger set of GCC versions now (since we've fixed compatibility with newer versions), but I'm not sure how much we care. We should keep the current pinned versions since that's what we actually deploy on Sapling, but if we move to other machines in the future likely we'll care about newer versions as well.
❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.25%. Comparing base (03e4e07) to head (5433364).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General notes:
About the source changes specifically:
using C = ...was causing Doxygen warnings, and the current build errors on any Doxygen warnings at all. We could potentially work around this differently (e.g., not making warnings a hard error)num_gpus=2in the Realm GPU model parallelism test, so I put that back herePasses local CPU and GPU CI on Sapling.
I should note: this also includes #1659 so you can merge that one separately or as a part of this PR.
This change is