Skip to content

Update and sync element unary/binary kernels - #1667

Open
elliottslaughter wants to merge 2 commits into
flexflow:masterfrom
elliottslaughter:element-binary
Open

Update and sync element unary/binary kernels#1667
elliottslaughter wants to merge 2 commits into
flexflow:masterfrom
elliottslaughter:element-binary

Conversation

@elliottslaughter

@elliottslaughter elliottslaughter commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

This is based on the assumption that ElementUnary is the template to follow (as it seems to be using the most modern code standards, as far as I can tell).

  • Update the ElementBinary interface and implementation to match the style of ElementUnary
  • Implement ElementBinary kernels for CPU (except for min/max)
  • Add tests
  • Minor updates to ElementUnary to make it more self-consistent (e.g., using consistent argument order everywhere)

I largely left the ElementBinary GPU kernel implementation alone; e.g., ElementUnary is a type-variadic implementation which I have made no effort to copy. However the GPU implementation should at least not regress and the external interface now matches the style of ElementUnary.


This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant