Lineardiff - #224
Merged
Merged
Conversation
The only conflict was in the error bounds table, where the two sides changed adjacent lines for unrelated reasons, so each side's own edit survives: master's updated `robust_irreg_step` rows come from the robustdiff normalization in 4ad25ee, which the branch never touched, while the loosened L-infinity bound on `lineardiff`'s first row is this branch's own change from 1513daf. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Collaborator
Author
|
I just ran the new thing in notebook 4, and the results are totally on par with any other method, so I think in spirit this one is done. Claude knocked it out of the park. I really should get in and touch and clean and fully 100% mathematically understand the files myself, but I think like |
…ultidim test
polydiff and lineardiff both documented window_size=None as "no sliding, fit globally" but rejected it in their required-argument checks, leaving the branch reachable only through the deprecated options={'sliding': False} route; dropping window_size from those checks makes the docstrings true and the two methods agree. That path has a longer history than it looks: the original dispatch stripped window_size off params only inside the sliding branch, so lineardiff's global fit raised ValueError from the first commit until the move to keyword arguments incidentally fixed it. Separately, lineardiff's multidimensionality test was fitting a noise-free surface at gamma=0.01, a heavy sparsity prior with no noise to trade fidelity against; gamma=1e-6 is three decades more accurate at the same runtime, so its bounds tighten from (2,1),(3,2) to (0,-1),(1,-1). Also corrects lineardiff's docstring, which described a polynomial fit and called order a polynomial degree rather than a count of states, allocates the output arrays as float so integer input cannot truncate through empty_like, and adds lineardiff to notebook 6 now that it takes an axis argument.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four main goals: