Repository navigation
fix: allow sibling placement inside repeated markup containers - #58
Open
MelmacAlpha wants to merge 1 commit into
Open
MelmacAlpha wants to merge 1 commit into
MelmacAlpha wants to merge 1 commit into
Conversation
Use the immediate source parent to distinguish ordinary markup children from JavaScript return roots. This keeps navigator moves within map containers on the byte relocation path instead of falling back to a whole-page diff and hitting its resource limit. Add 50 IPC regression cases for sibling and edge placement, nested scopes, exact Undo, external writers and code-owned return roots. The full local gate passes all 382 suites; the live hpmaas renderer move applies in two splices and Undo restores its original bytes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Navigator moves beside elements inside repeated markup containers were rejected and could fall back to a whole-page diff that exceeded the resource limit. Determine sibling placement from the immediate source parent so moves within an element or component preserve the original bytes and loop bindings. Direct JavaScript return roots remain protected.
Adds 50 IPC regression cases covering sibling and edge placement, nested scopes, exact Undo, external writers, and code-owned return roots, and updates the contract documentation.
Validation: the complete local pre-push gate passed all 382 test suites, including strict TypeScript, ESLint, production builds, and Studio verification.