Repository navigation
flutter_local_notifications_watchos: on flutter_local_notifications 23 - #42
Open
iamoguzhanarslantas wants to merge 1 commit into
Open
iamoguzhanarslantas wants to merge 1 commit into
iamoguzhanarslantas wants to merge 1 commit into
Conversation
The weekly upstream compatibility job fails on this package alone: pub.dev has flutter_local_notifications 23.0.2, a new major, and the package named ^22.3.2. Checked against 23.0.2, it moves there: * The iOS-facing Dart API is 22.3.2's: IOSFlutterLocalNotificationsPlugin keeps its members (the new canPostPromotedNotifications is Android's), and flutter_local_notifications_platform_interface 13.0.0 only raises the SDK minimum to Dart 3.12 and Flutter 3.44, which CI's 3.47.5 meets. * Upstream's iOS native code has one change, in 23.0.2: a request that asks for provisional authorization alone is made, and granted without a prompt, instead of answering false. _requestAuthorization counts provisional among the options that make a request, as upstream does. * The UNErrorDomain handling of 22.3.2 is unchanged, and upstream's official integration test is identical in both versions. pubspec.yaml and the example's name ^23.0.2; tool/upstream_versions.yaml and the README snippet 23.0.2. The header, the Dart doc of initialize, the README's "Following upstream", PORTING_REPORT and the CHANGELOG (0.0.1, still unpublished) follow. watchos_notifications_test.dart gets an unattended case: on a fresh install a provisional request alone answers true and checkPermissions reports provisional; it fails with the 22.3.2 behaviour. Checked on the watchOS 27.0 Simulator (Apple Watch Series 12, 46 mm): the watchOS test unattended from a fresh install (3 passed, 3 skipped), the same with 22.3.2's request check (the new case fails), with the prompt allowed (4 passed, 2 skipped), and upstream's official test (5 passed); the example exports every ffiSymbols entry. 15 host tests on 23.0.2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The weekly "Upstream compatibility" job has failed since flutter_local_notifications 23.0.0. Its only failure is
flutter_local_notifications_watchos: pub.dev has 23.0.2, a new major, and the package pinned^22.3.2. Following the job's instruction ("Check the package against it, then move both"), this checks the package against 23.0.2 and moves it there.What 22.3.2 → 23.0.2 changes for this package:
IOSFlutterLocalNotificationsPluginhas the same members as in 22.3.2; the only new method,canPostPromotedNotifications(), is onAndroidFlutterLocalNotificationsPlugin.flutter_local_notifications_platform_interface13.0.0 changes only the SDK minimum (Dart 3.12, Flutter 3.44); CI's Flutter 3.47.5 meets it. The rest of 23.0.0 is Android, Windows and Linux.requestPermissionsImpl. A request that asks for provisional authorization alone is now made instead of answeringfalsewithout asking, and the system grants it without a prompt. The watch's_requestAuthorizationmirrors this: provisional joins the options that count as "something requested".UNErrorDomainhandling from 22.3.2 (still ignored when adding a request; 23.0.0's README documents it).example/integration_test/flutter_local_notifications_test.dartis identical in 22.3.2 and 23.0.2, so it stays as is.Changes:
pubspec.yamland the example's:flutter_local_notifications: ^23.0.2.tool/upstream_versions.yamland the README snippet: 23.0.2._ffi.m(provisional counts), plus the matching comments and docs in_ffi.h, the Dart doc ofinitialize, README ("Following upstream" no longer says 23.0.0 is in development), PORTING_REPORT and CHANGELOG. The package is staged at 0.0.1 and unpublished, so the 0.0.1 entry gets the bullet.watchos_notifications_test.dart: a new unattended case,a provisional request alone is granted without a prompt. On a fresh install,requestPermissions(provisional: true)answers true andcheckPermissionsreports provisional. It skips itself when notifications are already allowed, and runs last because the grant stays for the rest of the run.Verified
On the watchOS 27.0 Simulator (Apple Watch Series 12, 46 mm):
watchos_notifications_test.dart, unattended from a fresh install: 3 passed (the launch,showwithout permission, the new provisional case) and 3 skipped. With 22.3.2's request check put back, the new case fails (Expected: true, Actual: false).--dart-define=FLNW_PROMPT=trueand the prompt allowed: 4 passed, 2 skipped.flutter_local_notifications_test.dart, after allowing the prompt: 5 passed.ffiSymbolsentry (dyld_info -exports).On the host:
tool/check,dart formatas CI runs it,pub publish --dry-runandtool/check_native_sources.sh(Xcode 27.1) are clean.tool/bin/upstream_compat.dart:all 23 packages resolve with their latest upstreamon this branch (exit 0), wheremainfails on this package.Not verified
nativejob covers it, and the one native change usesUNAuthorizationOptionProvisional, available since watchOS 5.🤖 Generated with Claude Code