Skip to content

network_info_plus_watchos: the start test waits its full budget - #43

Open
iamoguzhanarslantas wants to merge 1 commit into
flutterwatch:mainfrom
iamoguzhanarslantas:network-info-plus-watchos-start-test-budget
Open

iamoguzhanarslantas wants to merge 1 commit into
flutterwatch:mainfrom
iamoguzhanarslantas:network-info-plus-watchos-start-test-budget

Conversation

@iamoguzhanarslantas

Copy link
Copy Markdown
Contributor

Summary

The first of the two non-blocking points from the review of #41. In watchos_example_start_test.dart, the stopwatch started before the 3-second startup pump also timed the wait for the network info. With location already answered, the test therefore waited 7 seconds after startup, not the 10 seconds the old test allowed. The wait now has a stopwatch of its own, so it gets the full 10 seconds, or a minute while someone answers the prompt.

0.1.1 is not published yet (you're holding it for permission_handler_watchos), so its CHANGELOG entry gets a line instead of a new version.

Verified

  • The start test on the watchOS 27.0 Simulator (Apple Watch Series 12, 46 mm): it passes with location granted beforehand (xcrun simctl privacy … grant location), and skips its second part after reset location, as before.
  • flutter analyze of the example's integration_test/, every tool/ check, dart format as CI runs it, pub publish --dry-run and tool/check_native_sources.sh (Xcode 27.1): clean.

Not verified

  • A physical Apple Watch.

🤖 Generated with Claude Code

From the review of flutterwatch#41: the stopwatch started before the 3-second startup
pump also timed the wait for the network info, so with location answered
the test waited 7 seconds after startup rather than the 10 the old test
allowed. The wait now has a stopwatch of its own. 0.1.1 is not published
yet, so its CHANGELOG entry says so instead of a new version.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant