Repository navigation
network_info_plus_watchos: the start test waits its full budget - #43
Open
iamoguzhanarslantas wants to merge 1 commit into
Open
iamoguzhanarslantas wants to merge 1 commit into
iamoguzhanarslantas wants to merge 1 commit into
Conversation
From the review of flutterwatch#41: the stopwatch started before the 3-second startup pump also timed the wait for the network info, so with location answered the test waited 7 seconds after startup rather than the 10 the old test allowed. The wait now has a stopwatch of its own. 0.1.1 is not published yet, so its CHANGELOG entry says so instead of a new version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The first of the two non-blocking points from the review of #41. In
watchos_example_start_test.dart, the stopwatch started before the 3-second startup pump also timed the wait for the network info. With location already answered, the test therefore waited 7 seconds after startup, not the 10 seconds the old test allowed. The wait now has a stopwatch of its own, so it gets the full 10 seconds, or a minute while someone answers the prompt.0.1.1 is not published yet (you're holding it for
permission_handler_watchos), so its CHANGELOG entry gets a line instead of a new version.Verified
xcrun simctl privacy … grant location), and skips its second part afterreset location, as before.flutter analyzeof the example'sintegration_test/, everytool/check,dart formatas CI runs it,pub publish --dry-runandtool/check_native_sources.sh(Xcode 27.1): clean.Not verified
🤖 Generated with Claude Code