Repository navigation
Conversation
The start-time filter change made executionSortFields.createdAt execution_created_at. Only the executions list accepts that key, so flyteadmin rejected the node execution, workflow, task, launch plan and description entity requests with "invalid sort key". Execution lists now use executionCreatedAt and everything else is back on created_at. Signed-off-by: 1fanwang <1fannnw@gmail.com>
5 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Since #942, opening an execution in the console against flyteadmin shows a spinner that never stops, so its nodes and the Relaunch button never appear. The workflow, task and launch plan pages also show "Failed to fetch data / Bad Request" for their versions and descriptions. flyteadmin rejects each of those requests with:
The change is not in a release yet; v1.23.0 predates it.
Type
Are all requirements met?
Complete description
The pull request above changed the shared creation-time sort so that execution lists sort by when the execution was created. The console uses that same sort for node executions, workflows, tasks, launch plans and descriptions, and flyteadmin understands the execution-specific key only on the executions list. For every other list it refuses the request as an invalid sort key.
This gives execution lists their own sort and puts every other list back on its own creation time, so the start-time filter behavior from the earlier change stays.
Tracking Issue
N/A. The regression comes from #942.
Follow-up issue
NA
Testing Done
I ran the console dev server against a Flyte v1.16.4 sandbox and opened the execution, workflow, task, launch plan and project executions pages with Playwright, on master at 73d8292 and on this branch at 460a967. A small proxy serves the console and admin from one origin, as a deployment does.
Setup:
The seed execution axxqf52fctjt47dmbcds succeeded. Console, from the repository root, with a self-signed pair because the dev server exits without one:
The admin rejects the key directly, and accepts created_at on the same request:
Master, 73d8292:
This branch, 460a967:
Execution lists keep execution_created_at, and every other list is back on created_at. The task page shows "No executions found" in both runs because the seed launched the workflow, not the task directly.
Reproducer source: wf_8105.py
Reproducer source: proxy.js
Reproducer source: crawl_sort.py