Skip to content

fix: skip unmatched execution inputs #patch - #949

Open
stantheman0128 wants to merge 1 commit into
flyteorg:masterfrom
stantheman0128:fix/8038-skip-unknown-input-literals
Open

stantheman0128 wants to merge 1 commit into
flyteorg:masterfrom
stantheman0128:fix/8038-skip-unknown-input-literals

Conversation

@stantheman0128

Copy link
Copy Markdown

TL;DR

Opening an execution crashes when a node input key is not on the resolved task interface. Rerun and resume prefill now skip that key, so the page still renders.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

literalsToLiteralValueMap reads nameToTypeMap[name].type for every literal. Rerun and resume call it while the execution page is rendering, so one unknown key (a dynamic node child, or a task registered with a different signature) hits the error boundary: Cannot destructure property 'type'.

Keys that are on the interface are still stored under the same cache key. Unknown keys are left out of the prefill map.

The new unit test fails on master with that TypeError and passes after this change. Ran literalsToLiteralValueMap.test.ts (2 tests) with Node 24. CI uses Node 18. The browser was not opened.

AI assistance: Cursor Grok. The author reviewed the diff.

Tracking Issue

fixes flyteorg/flyte#8038

Follow-up issue

NA

Rerun and resume build the launch form while rendering. A literal key that the resolved interface does not declare crashed the execution page.

Signed-off-by: Po-Han Shih <stanshih888@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Console crashes with "Cannot destructure property 'type'" when a node execution's inputs don't match the resolved task interface

1 participant