Repository navigation
fix: skip unmatched execution inputs #patch - #949
Open
stantheman0128 wants to merge 1 commit into
Open
stantheman0128 wants to merge 1 commit into
stantheman0128 wants to merge 1 commit into
Conversation
Rerun and resume build the launch form while rendering. A literal key that the resolved interface does not declare crashed the execution page. Signed-off-by: Po-Han Shih <stanshih888@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Opening an execution crashes when a node input key is not on the resolved task interface. Rerun and resume prefill now skip that key, so the page still renders.
Type
Are all requirements met?
Complete description
literalsToLiteralValueMapreadsnameToTypeMap[name].typefor every literal. Rerun and resume call it while the execution page is rendering, so one unknown key (a dynamic node child, or a task registered with a different signature) hits the error boundary: Cannot destructure property 'type'.Keys that are on the interface are still stored under the same cache key. Unknown keys are left out of the prefill map.
The new unit test fails on master with that TypeError and passes after this change. Ran
literalsToLiteralValueMap.test.ts(2 tests) with Node 24. CI uses Node 18. The browser was not opened.AI assistance: Cursor Grok. The author reviewed the diff.
Tracking Issue
fixes flyteorg/flyte#8038
Follow-up issue
NA