Fix CI after dev dependency update - #1777
Merged
Merged
Conversation
diegomura
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ea51c47 (Update dev dependencies) broke CI in two ways. Since the workflow only runs on pull requests, master went red silently and every open PR currently fails.
lib/font/embedded.jsandtests/unit/pdfa1.spec.jsfailnpm run prettier -- --check. Reformatted (2 lines).ArrayBuffer.prototype.transferToFixedLength— a Node 21+ API — so all visual tests fail on the Node 20 job. Pinned back to ^5 since the package still supports Node 20 (engines) and pdfjs-dist is only a devDependency used to render visual-test snapshots. It can move to ^6 whenever the Node requirement is raised to 22+.Full suite (520 tests including visual) verified locally on Node 20.