Skip to content

Fix SF CLI integration mock server - #139

Merged
markdlv-sf merged 6 commits into
mainfrom
fix-deploy-mockserver
Aug 19, 2026
Merged

Fix SF CLI integration mock server#139
markdlv-sf merged 6 commits into
mainfrom
fix-deploy-mockserver

Conversation

@markdlv-sf

Copy link
Copy Markdown
Contributor

No description provided.

@jcatt-sf
jcatt-sf self-requested a review August 18, 2026 20:35

@jcatt-sf jcatt-sf left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of the TLS mock-server change. Overall a clean, well-commented PR — the inline notes are mostly diagnosability / latent / maintainability, with one ordering issue worth looking at before merge (the readiness gate racing the server's TLS setup, on scripts/mock_sf_server.py).

Common root cause. Several notes (the readiness race, the cert-file TOCTOU, the 9× path duplication, and the worktree placement) all trace back to one decision: generating the cert lazily inside the mock server's own startup, after installs. Generating it once in an early dedicated CI step — and separating cert-gen from the TLS bind, printing liveness before signaling ready — would collapse those four into a single fix.

(One earlier candidate — an allow_reuse_address ordering concern — was checked empirically and dropped as a false positive.)

Comment thread scripts/mock_sf_server.py Outdated
Comment thread scripts/mock_sf_server.py Outdated
Comment thread scripts/mock_sf_server.py Outdated
Comment thread scripts/mock_sf_server.py Outdated
Comment thread .github/workflows/sf_cli_integration.yml Outdated
Comment thread .github/workflows/sf_cli_integration.yml Outdated
@markdlv-sf
markdlv-sf merged commit da11b86 into main Aug 19, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants