Skip to content

A commit a shallow clone was cut at prints PASS for a whitespace check that was not made #93

Open

Description

@closer-claudio

In a shallow clone, the commit the clone was cut at cannot have its whitespace checked: its parents are not there, and git shows it as adding the whole tree. The dangling-whitespace rule skips it, says so under -D only, and reports PASS.

So a run with no range in a clone of depth 1, which is what actions/checkout makes by default, checks no whitespace at all, prints PASS, and says nothing. This was already so before #92, which keeps it as it found it.

What to do

  • validate.Result gains a third state: not checked.
  • Under -v the rule's line is - SKIP - whitespace not checked: the commit's parents are not in this shallow clone.
  • The commit's own line stays the verdict of the rules that ran, and the exit status with it.
  • A warning on standard error, once per run and at every verbosity (-q included), names the commit and what to fetch: a depth of 2, or a range.

Rows

  • a clone of depth 1 with no range: the warning, the SKIP line under -v, exit 0; the warning under -q too;
  • a clone of depth 2: checked, no warning;
  • a whole clone's first commit: checked.

A consumer that parses the report sees one new rule line under -v in a shallow clone; commit lines and the exit status do not move.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions