Skip to content

The lint backlog no longer exempts the runner from three linters that find nothing there - #85

Merged
closer-claudio merged 1 commit into
mainfrom
claudio/20261115-lint-dead-exclusions
Nov 15, 2026
Merged

closer-claudio merged 1 commit into
mainfrom
claudio/20261115-lint-dead-exclusions

Conversation

@closer-claudio

Copy link
Copy Markdown

🎯 Why

The onboarding lint backlog in .lint-go.yaml still exempted validate/runner.go from three linters that find nothing in it any more: forbidigo (7 findings at enrolment), varnamelen (2) and err113 (1). The runner has since stopped printing (it reports through Runner.Report), its errors are wrapped, and the short names are gone. An exemption with nothing behind it would let the next such finding in unseen.

For #37, the backlog.

🛠️ What

  • .lint-go.yaml: the three exemptions for validate/runner.go go; the file's count drops from 11 to 1 (gocognit, still found, stays).

🧪 How

  1. lint: the backlog stops naming what validate/runner.go no longer has
    • V: just lint and just test pass on macOS arm64 (57 tests): with the three exemptions removed, just do lint go finds nothing in the file.
    • V: the control: with the entry for cmd/git-validation/main.go taken out as well, its five findings come back (forbidigo 3, gocognit 1, revive 1), so the lint does look at what the block stops exempting. That entry is untouched.
    • U: Linux and Windows, left to CI.

📝 Notes

  • Lint configuration only: nothing changes for someone who runs the command or imports the packages.

The backlog block exempted validate/runner.go from forbidigo (7
findings at enrolment), varnamelen (2) and err113 (1). The runner has
since stopped printing (it reports through Runner.Report), its errors
are wrapped, and the short names are gone: with the three exemptions
removed, `just do lint go` finds nothing in the file. gocognit's one
finding there is still found and stays.

The entry for cmd/git-validation/main.go stays whole: taken out, its
five findings come back (forbidigo 3, gocognit 1, revive 1).

For #37.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Signed-off-by: closer-claudio <claudio@farcloser.world>
@closer-claudio closer-claudio added the internal Changes nothing for a consumer: tooling, CI, maintainers' docs; left out of the notes label Nov 15, 2026
@closer-claudio

Copy link
Copy Markdown
Author

Reviewed at a5cbf6f

@closer-claudio
closer-claudio merged commit 8acd761 into main Nov 15, 2026
14 checks passed
@closer-claudio
closer-claudio deleted the claudio/20261115-lint-dead-exclusions branch November 15, 2026 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Changes nothing for a consumer: tooling, CI, maintainers' docs; left out of the notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants