Repository navigation
DRAFT: checkout, success, cancel and resend pages (test mode, config off) - #184
Draft
fosterstack-admin wants to merge 5 commits into
Draft
fosterstack-admin wants to merge 5 commits into
fosterstack-admin wants to merge 5 commits into
Conversation
…node tests (flag off, test mode only)
Deploying www with
|
| Latest commit: |
f37a498
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://981e35fb.www-4rw.pages.dev |
| Branch Preview URL: | https://www-checkout-pages.www-4rw.pages.dev |
Contributor
Author
|
The file-allowlist check (bin/check-file-allowlist.sh) is red on exactly four paths of this PR. The edit to that guard was refused to me, so here is the exact change, for whoever the owner names to apply it (it adds four exact patterns before the '^bin/test-live-check\.sh$'
+ '^checkout\.js$'
+ '^checkout-config\.js$'
+ '^tests/checkout\.test\.js$'
+ '^checkout/(success|cancel)/index\.html$'
'^\.github/workflows/[A-Za-z0-9_-][A-Za-z0-9._-]*\.ya?ml$'(The line |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HOLD (owner, Oct 26: "I am not ready for a buy page to go live."): this PR stays DRAFT. No ready mark, no merge and no allowlist or exception-list edit, whatever the checks say, until the owner's explicit go in the advisor's conversation.
DRAFT. Test mode only. Config is OFF: no buy button is active, no page makes a request, until the owner's apply gives the three addresses.
Builds the www side of payments SB-10.2 (checkout), SB-10.4 (cancel), SB-10.5 (success), SB-10.6 (resend). Base: www#33's shells, moved to
/checkout/success/and/checkout/cancel/to match the Terraform success and cancel URLs./buy/,/checkout/success/,/checkout/cancel/,/resend-key/;checkout.js(one same-origin file, no inline script);checkout-config.js(enabled:false).{product:"cache",tier,interval}+Idempotency-Keyto the checkout address; oneGET /v1/entitlement?s=from the success page (one more only on "Check again");{email}from the resend page. No cookie, no storage, no console, values inserted as text, the Stripe URL followed only onhttps://checkout.stripe.com.test_wb_11_...).TODO-COPYfor the owner.node --test tests/(22, written first).Known red: the file-allowlist hygiene check fails on exactly these four paths. The change is the owner's to make; nobody edits
bin/check-file-allowlist.shuntil he says so. The four lines:Not in this PR (held): the
_headersCSPconnect-srcedit (exactly the three backend origins, no wildcard) and the hygiene-workflow step that runs the node tests; both ride with the real addresses after the apply (read-back approved by the advisor). The WB-1..19 ACs are unratified drafts, so this does not merge until the owner ratifies them.