Repository navigation
Group vitest updates and ignore @types/node majors in Dependabot - #46
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Dependabot's first run after #40 opened separate pull requests for
vitest(#43) and@vitest/coverage-v8(#44). Each failednpm ci, because@vitest/coverage-v85.0.5 needs exactlyvitest5.0.5. It also opened #42, which bumped@types/nodefrom 20 to 26. Node 26 types would let code use APIs that Node 22, the oldest supported version, lacks, and the type check wouldn't catch it.What
Dependabot now updates
vitestand every@vitest/*package together in one pull request, majors included, and no longer proposes major updates to@types/node.Changes
.github/dependabot.yml:vitestgroup matchingvitestand@vitest/*, placed before the minor-and-patch group so it takes those packages first.ignorerule for@types/nodeversion-update:semver-major.Testing
vitest, thennpm-minor-and-patch, followed by the@types/nodeignore rule.Risk and rollout
None. This changes only which update pull requests Dependabot opens.
Notes for reviewers
@types/nodestays at^20.14.15, below the oldest supported Node, 22. Moving it to^22is a separate change.vitest.config.tsif vitest 5 changed its coverage options. Its CI will show that.🤖 Generated with Claude Code