Repository navigation
Update vitest and coverage-v8 to 5 with Node 22 types - #49
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Dependabot's vitest 5 pull requests (#43, #44, then #47) each failed
npm ci, for two reasons:@vitest/coverage-v8must be exactly the same version asvitest.@types/node^22.0.0 || >=24.0.0, and the repository had^20.Closing #44 also made Dependabot ignore
@vitest/coverage-v85.0.5, so its group could not pick it up again. This pull request makes all three updates in one change.What
The tests now run on vitest 5. The Node types move to 22, the oldest Node the package supports.
Changes
package.json:vitestgoes from^4.1.12to^5.0.5.@vitest/coverage-v8goes from^4.1.12to^5.0.5.@types/nodegoes from^20.14.15to^22.20.5.No config change was needed.
Testing
npx tsc --noEmitpasses with the Node 22 types.npm run checkpasses: lint, build, all 181 tests under the 99/99 coverage gate, and the examples.npm run auditfinds 0 vulnerabilities, andnpm run test:packageconfirms the packed package installs and runs.npm run coverage:modulereports 100% lines and branches for every module.npm run test:visualpasses 9 of 9, afternpx playwright install chromiumfetched the browser that Bump the npm-minor-and-patch group with 2 updates #41's Playwright update needs.Risk and rollout
None. These are development dependencies only, and
npm packcontents are unchanged.Notes for reviewers
@types/node20.19.43) after this merges, if Dependabot doesn't close them itself. Both are superseded.🤖 Generated with Claude Code