Repository navigation
Drop the dev branch from CI and tidy the release workflow - #50
Merged
Merged
Conversation
The dev branch is deleted, so CI no longer lists it. The release workflow's second tag pattern was redundant, and the tag check now runs before the audit, build and tests so a mismatched tag fails fast. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
devbranch is gone ("we can drop dev and clean up the ymls"), and the workflows still referred to it, along with two small things in the release workflow.What
CI runs on pushes to
masterand on pull requests only. The release workflow triggers on one tag pattern, and it checks the tag againstpackage.jsonbefore doing any other work.Changes
ci.yml: removesdevfrom the branches whose pushes run CI. The branch was merged intomasterand deleted.release.yml, tags: drops the'v*.*.*-*'pattern. GitHub's*matches any characters except/, so'v*.*.*'already matches pre-release tags such asv4.1.0-rc.1.release.yml, version check: "Verify tag matches package version" moves from after the tests to straight afternpm ci, so a tag that doesn't match the version fails in seconds.Testing
master, releases on the single patternv*.*.*, and the release steps now run checkout, setup-node,npm ci, the version check, the audit and then the build.Risk and rollout
None. The next tag push runs the reordered release workflow; if the tag matches the version, it publishes exactly as before.
🤖 Generated with Claude Code