Repository navigation
Fix nested quotations in browser, React and Vue starters - #55
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The browser, React and Vue demos rendered nested generated quotations as
[outer[inner]endwhen a containing element used block layout. Upgrade only these three starters from the published Fullbleed 0.8.2 package to 0.8.3, which renders[outer{inner}end]. The core engine pin and root package remain unchanged.Add editor/download regression checks for inline, block and contents layouts, with exact text from two PDF readers, page geometry and visible preview output. Keep the existing cancellation, source isolation and framework lifecycle checks. Include the new fixture in all three workflow path filters.
Local Chrome verification passes 94 browser, 143 React and 102 Vue checks. Nine quotation downloads pass; the healthy controls and all 27 prior document downloads remain byte-identical. Installed files match the public npm tarball. Retain the observed failures and scoped verification record in
verification/starters-083.json; CI exercises the remaining browser matrix and React development paths.