[khushalsonawat]

Summary

Follow-up to #268, which is merged, for two review comments.

• A model inside a multi-line block comment (model_citation.py). An unclosed /* or <!-- now stays open across lines until its */ or -->, so a model written inside one is refused. Before, the comment ended with its own line, so a model on line 2 of a /* ... */ block was accepted.
  • block_open_before tracks triple quotes, */ and -->.
  • It passes the SQL -- and INI ; comment settings to the scan, so -- see /* or ; <!-- opens no false block.
  • model_problems always passes the open block.
  • Text after a closer, and blocks closed on one line, behave as before.
• Unconfirmed lines are no longer saved as the prompt (tools.py). When the named lines fail twice against a quote of fewer than 16 letters, no prompt is saved (system_prompt_excerpt is empty, system_prompt_from is cleared), and the lines are kept only in unconfirmed_prompt_from. A quote of 16 letters or more is kept as before.
  • The replies, and the understand-agent skill text, say so.
  • One behaviour changes: a placeholder quote with the right lines used to save those lines, and now saves no prompt.

Linear: TH-8953.

Verification

• uv run ruff check .: no new findings in the changed files (22 before, 22 after)
• Focused pytest target: tests/harness/test_contract_model.py tests/harness/test_seed_rows.py tests/test_harness.py, on Python 3.12.3.
  • The failures are identical by name before and after: six pre-existing failures in test_harness.py.
  • 5 new test functions cover a model inside a block over lines (refused), one after a closer (accepted), no false blocks from strings, URLs, globs, SQL or INI comments, linear time on 1 MiB files, and the short-quote outcome.
  • Each of the deliberate breaks tried was caught by a named test.
• Full uv run pytest -q when touching shared runtime, CLI, SDK, or release gates (not run; the change is confined to the model citation check and the prompt branch)
• TypeScript build/test when touching typescript/ (not touched)
• agent-learn release-proof when touching release-candidate behavior (not touched)

Known limits:

• A block comment is carried to later lines only when its closer (*/ or -->) is on a later line of the file. <!-- is carried in every file but known code languages and configuration. So a stray /* that isn't a comment (a regex like /\/*/g) still hides the lines up to a later */ anywhere in the file. A <!-- inside a Vue or Svelte <script> block carries to a later -->. In both cases a correct model is refused, then left out: it fails safe.
• XML written under .conf or .cfg, and markup named like configuration by itself (Dockerfile.xml, .env.xml), are read as configuration. There a model inside a real multi-line <!-- --> comment is accepted. No such file was found in our repos.
• test_a_crafted_python_file_does_not_hold_up_the_conversation fails on CI (a 0.38-0.40 s stall against its 0.25 s limit) on this branch's base too, and on its other PRs. It comes from the base, not from this change.
• Nothing on the platform reads unconfirmed_prompt_from yet.

Checklist

• Public API names stay under agent_learning.*, agent-learn, or @future-agi/agent-learning-kit
• New user-facing workflow has docs or an example (no new workflow)
• New release claim has executable gate coverage (no release claim)
• No hosted-service dependency was added to release-gated examples
• Security-sensitive output is redacted or justified

[cdileep23]

Please check the comments.

[cdileep23]

P3. An opener that isn't a comment now hides the rest of the file, so an honest model below it is refused and then left out. <!-- is carried across lines in every file, and /* in every block-comment language, even where the line holds no comment.

Before this change each of these kept gpt-4o on the next line as the model; now it is refused:

• a.js: const isComment = /<!--/.test(s); (a regex literal)
• a.js: const re = /\/*/g;
• c.yaml: banner: <!-- top
• .env: BANNER=<!--
• a.sh: a heredoc holding <!-- header
• a.ts: a multi-line template literal holding /* todo with no closer

Fix: carry a block to later lines only when its closer (*/ or -->) appears on a later line, since an unterminated comment doesn't compile anyway. Also carry <!-- only in markup files (.html, .xml, .vue, .svelte), where it is a comment.