Repository navigation
[TH-9448] fix: no traceback at any log level when the browser scan skips a file - #291
Merged
khushalsonawat merged 2 commits intoNov 11, 2026
Conversation
…ps a file (TH-9448) Dileep's review of #288: the skip handler still logged the path with the full traceback at DEBUG, and a tokenizer or parser trace can quote a line of the customer's source. That is safe only while every hosted logger stays at INFO. The handler now logs the path and the error type at DEBUG, and the type alone at WARNING once a scan, as _python_markers already does. The skip test asserts that no record at any level carries a traceback or the error's own text. Reviewed by two fresh reviewers, both CLEAR. Refs: TH-9448 Signed-off-by: khushalsonawat <khushalsonawat@gmail.com>
cdileep23
approved these changes
Nov 11, 2026
…nto feat/TH-9448-no-debug-trace Signed-off-by: khushalsonawat <khushalsonawat@gmail.com>
khushalsonawat
merged commit Nov 11, 2026
2ea884f
into
feat/TH-8804-source-subfolder
11 checks passed
5 of 10 tasks
khushalsonawat
added a commit
that referenced
this pull request
Nov 11, 2026
…the-parse-total agent_type_check.py, the skip handler: #291 drops the trace at every level; this branch counts a skip as the skipped cut. Kept both: no trace, the type once at WARNING, the count in the cut line. Signed-off-by: khushalsonawat <khushalsonawat@gmail.com>
15 of 16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #288, answering Dileep's two comments there; #288 was merged before they could go in.
agent_type_check.py:648) is fixed. The browser scan's skip handler logged the path with the full traceback at DEBUG. A tokenizer or parser trace can quote a line of the customer's source, so that was safe only while every hosted logger stays at INFO. Now::329) is not changed. See the reply on that thread. In short, mtime in the key stops exact copies of a vendored environment from sharing (measured: 9 of 21 copies get rows again, as before [TH-9448] fix: follow-ups from #224's last review of the browser-agent scan #288). A same-size patch to a vendored file can't share wrong rows, because only each RECORD's paths are kept. It stays a named known limit.Type of Change
Testing
test_agent_type_refusal.py: 720 passed.test_a_skip_logs_its_type_once_and_its_path_at_debug_only_with_no_tracered.Related Issues
Refs: TH-9448