Repository navigation
[TH-9491] docs: answer Dileep's review of #278 - #292
Merged
khushalsonawat merged 1 commit intoNov 11, 2026
Merged
Conversation
…(TH-9491) Dileep's review of #278 (contract.py): a process note in a docstring tells a reader nothing. The sentence already says why a subclass such as an OrderedDict is walked. Refs: TH-9491 Signed-off-by: khushalsonawat <khushalsonawat@gmail.com>
cdileep23
approved these changes
Nov 11, 2026
khushalsonawat
merged commit Nov 11, 2026
7a3aefb
into
feat/TH-8804-source-subfolder
11 checks passed
5 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #278, which merged with Dileep's review open. Each of his eight points is answered on its thread. The only code change is his docstring point. The rest are either owned by another open ticket or named as limits:
/,?or#(P1, and the P3 on#/?) is a real leak, which existed before [TH-9491] fix: keep URL credentials in an agent's description out of what the kit sends and stores #278. It is TH-9500's: its rule 1 removes such a password before the address step, with guards that keep honest text likelocalhost:3000 … support@acme.comintact. TH-9500 (Birch) is in change review now. A cut in_redact_urlwas tried here. Its review found that it would conflict with rule 1 and needed more guards of its own, so it isn't in this PR.//user:pass@hostandscheme:\\user:pass@host(P2) are named as a TH-9500 limit. The finder starts an address only at://, which the streaming chat cleaner shares.Type of Change
Testing
A docstring-only change to
src/fi/alk/harness/contract.py.Related Issues
Refs: TH-9491