Skip to content

[TH-9491] docs: answer Dileep's review of #278 - #292

Merged
khushalsonawat merged 1 commit into
feat/TH-8804-source-subfolderfrom
feat/TH-9491-dileep-follow-ups
Nov 11, 2026
Merged

khushalsonawat merged 1 commit into
feat/TH-8804-source-subfolderfrom
feat/TH-9491-dileep-follow-ups

Conversation

@khushalsonawat

Copy link
Copy Markdown
Member

Description

Follow-up to #278, which merged with Dileep's review open. Each of his eight points is answered on its thread. The only code change is his docstring point. The rest are either owned by another open ticket or named as limits:

Type of Change

  • Documentation

Testing

A docstring-only change to src/fi/alk/harness/contract.py.

Related Issues

Refs: TH-9491

…(TH-9491)

Dileep's review of #278 (contract.py): a process note in a docstring tells a
reader nothing. The sentence already says why a subclass such as an
OrderedDict is walked.

Refs: TH-9491
Signed-off-by: khushalsonawat <khushalsonawat@gmail.com>
@khushalsonawat khushalsonawat self-assigned this Nov 11, 2026
@khushalsonawat
khushalsonawat merged commit 7a3aefb into feat/TH-8804-source-subfolder Nov 11, 2026
11 checks passed
@khushalsonawat
khushalsonawat deleted the feat/TH-9491-dileep-follow-ups branch November 11, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants