Repository navigation
fix: preserve CarPlay physical size across browser viewport changes - #36
Merged
fython merged 1 commit intoOct 23, 2026
Merged
Conversation
A smaller browser canvas was reported as a fraction of the largest viewport ever observed. With Medium and a saved 3840-pixel maximum, 1184x920 was announced as 93x72 mm, making iOS controls oversized. Use the current canvas as the physical reference so the selected length remains stable across browser resizing and pixel-resolution changes. Keep the shared resolver's existing width/height reference handling. Add host regressions for the reported dimensions, repeated resizing, all size presets, and a saved height reference. All four fail against the original code and pass with the fix.
Contributor
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Owner
|
@TioaChan Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A smaller browser viewport could make CarPlay icons and text grow because the host reported its physical size as a fraction of the largest viewport previously observed. For example, Medium's 300 mm width became 150 mm when a canvas changed from 3840 to 1920 pixels wide.
Use the current browser canvas as the physical-size reference, keeping the configured reference length stable while deriving the other dimension from the current aspect ratio. The shared resolver continues to handle both width and height references.
Add four regressions against the actual host calculation: a smaller canvas after a 4K viewport, repeated resizing and lower pixel resolution, each size preset, and a saved height reference. All four fail with the original calculation and pass with this change.
Validation:
Fixes #35