Repository navigation
ci: stop adding risk:t labels in risk workflow - #91
Merged
Merged
Conversation
Co-authored-by: Gabe <gabe4coding@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
The risk workflow adds a risk:t label on each pull request. Delete the label step. The workflow posts the risk tier check. Labels stay as they are.
%%{init: {'theme': 'neutral'}}%% flowchart TD A[A pull request updates] --> B{"Run the base copy?"} B -->|yes| C[Classify the change] C --> D[Post the risk tier check] D --> E[Leave labels unchanged] B -->|no| F[Run the classifier tests]Risk
R0 (R0: review all of it; R1: review the items below; R2: no review needed): The diff edits
.github/workflows/risk.yml, an R0 file whose job runs on pull_request_target with write tokens.ℹ️ 2 items need you: 1 critical, 1 validation gap. Open to see them.
Needs you
.github/workflows/risk.yml:116Validation gaps
.github/workflows/risk.yml:116Drift
Drift is a difference from the request. None.
Decisions
The request settles every choice. It keeps the permissions, the classifier outputs, and the check run.
Door: two-way. A revert restores the label step.
Evidence
The tier job runs on pull_request_target. GitHub runs the workflow from the base branch. A pull request of this branch still receives a risk:t label from that copy. Existing risk:t labels stay.
Job permissions stay read for contents and issues, and write for pull requests and checks.
python3 -m pytest -q .github/scripts<code>Classify, Label, Check run "risk tier"</code><code>Classify, Check run "risk tier"</code>risk:matchesReading map
A signal is a change kind that reaches code outside this diff.
Config
.github/workflows/risk.ymllines 2–3, line 56, and line 116.