goto: keep the app path when the base url has a query or hash (#108) by gabe-bots[bot] · Pull Request #116 · gabe4coding/plain

gabe-bots · 2026-10-26T08:41:06Z

Step 1/3 of quality/108-goto-query. Previous: none. Next: quality/107-useid-fragment.

Part of #108

Intent

A relative goto stays under the base path. A base query or hash stays unless the target has its own. Credentials in the base url stay.

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  base["base url with query or hash"] --> resolve["resolveUrl"]
  target["relative target"] --> resolve
  resolve --> path["keep the base directory"]
  path --> carry["copy query and hash unless the target has a ? or #"]
  carry --> page["page loads under the base path"]

Drift

None.

Decisions

Search and hash copy independently. A target with only a query still receives the base hash. Door: two-way. One function and one doc sentence can change later.
An empty ? or # in the target clears that part of the base url. Door: two-way.
A target with its own scheme, such as data: or https:, stays unchanged. Door: two-way.

Evidence

Before: http://host/app?x=1 + /login → http://host/login. http://host/app#section + /login → http://host/login. Fail-first: expected http://host/app/login?x=1, actual http://host/login.

After: http://host/app?x=1 + /login → http://host/app/login?x=1. #section → http://host/app/login#section. Browser goto from http://127.0.0.1:45659/app?from=e2e loaded http://127.0.0.1:45659/app/login?from=e2e, title App login, search ?from=e2e.

npm run verify: 578 pass, 0 fail. docs ok 18. Baseline was 577 pass, 0 fail. Live e2e did not finish: Connection error: fetch failed.

Review round 1

Before: https://user:pass@host/app + /login became https://host/app/login. /login? kept ?x=1. /login# kept #section. Fail-first: 3 fail, 1 pass.

After: the credential url stays https://user:pass@host/app/login. /login? becomes https://host/app/login?#section. /login# becomes https://host/app/login?x=1#. npm run verify: 581 pass, 0 fail. Head 5041210. The branch was rebased onto main after #115 merged, so verify ran on the commits before the rebase.

Reading map

Tests changed: src/browser/steps.test.ts (new test), scripts/gates.test.mjs (e2e floor 38 to 39).
Config: e2e/goto-base-query.yaml.
Public API: resolveUrl is now exported from src/browser/steps.ts.

Stack

Step 1/3 of quality/108-goto-query. Previous: none. Next: quality/107-useid-fragment.

gabe-bots · 2026-10-26T08:41:16Z

@greptileai review

gabe4coding · 2026-10-26T08:45:04Z

@greptile review

greptile-apps · 2026-10-26T08:48:50Z

Confidence Score: 4/5

[Medium impact] Changes how the goto step resolves relative URLs.

Preserve base URL credentials before merging; relative navigation can otherwise fail on protected sites.

Findings

Relative navigation drops credentials ▶
Empty overrides keep base values ▶

Fix with agent prompt

### Issue 1
src/browser/steps.ts:179
`resolveUrl` rebuilds the base using `parsed.origin`, which excludes its username and password. For example, `https://user:pass@host/app` plus `/login` now becomes `https://host/app/login`; previously the credentials stayed.

If a spec supplies credentials through its base URL without a separate `auth` block, relative navigation can no longer open the protected page. Build the directory URL from `parsed` without discarding its credentials.

### Issue 2
src/browser/steps.ts:180-181
`resolveUrl` treats an explicitly empty query or hash as missing. With base `https://host/app?x=1#section`, `/login?` restores `?x=1`, and `/login#` restores `#section`. Users cannot clear the inherited query options or hash route this way.

The URL getters return an empty string for both absent and explicitly empty values. Check whether the target supplied each delimiter before copying the base value, and add tests for empty overrides.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Keeps relative goto paths under the app directory when the base URL has a query or hash.

Relative goto keeps the app path and URL suffixes.

_{Reviews (1) · Last reviewed commit: "Merge origin/main into quality/108-goto-..." · Reviewed by Greptile}

greptile-apps · 2026-10-26T08:48:53Z

+  const directory = parsed.pathname.endsWith('/') ? parsed.pathname : `${parsed.pathname}/`;
  const relative = target.startsWith('/') ? target.slice(1) : target;
-  return new URL(relative, baseWithSlash).toString();
+  const resolved = new URL(relative, `${parsed.origin}${directory}`);


Relative navigation drops credentials

resolveUrl rebuilds the base using parsed.origin, which excludes its username and password. For example, https://user:pass@host/app plus /login now becomes https://host/app/login; previously the credentials stayed.

If a spec supplies credentials through its base URL without a separate auth block, relative navigation can no longer open the protected page. Build the directory URL from parsed without discarding its credentials.

Prompt To Fix With AI

This is a comment left during a code review. Path: src/browser/steps.ts Line: 179 Comment: **Relative navigation drops credentials** `resolveUrl` rebuilds the base using `parsed.origin`, which excludes its username and password. For example, `https://user:pass@host/app` plus `/login` now becomes `https://host/app/login`; previously the credentials stayed. If a spec supplies credentials through its base URL without a separate `auth` block, relative navigation can no longer open the protected page. Build the directory URL from `parsed` without discarding its credentials. --- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fixed in 5041210: a relative goto keeps the user name and password from the base url.

greptile-apps · 2026-10-26T08:48:53Z

+  if (!resolved.search) resolved.search = parsed.search;
+  if (!resolved.hash) resolved.hash = parsed.hash;


Empty overrides keep base values

resolveUrl treats an explicitly empty query or hash as missing. With base https://host/app?x=1#section, /login? restores ?x=1, and /login# restores #section. Users cannot clear the inherited query options or hash route this way.

The URL getters return an empty string for both absent and explicitly empty values. Check whether the target supplied each delimiter before copying the base value, and add tests for empty overrides.

Prompt To Fix With AI

This is a comment left during a code review. Path: src/browser/steps.ts Line: 180-181 Comment: **Empty overrides keep base values** `resolveUrl` treats an explicitly empty query or hash as missing. With base `https://host/app?x=1#section`, `/login?` restores `?x=1`, and `/login#` restores `#section`. Users cannot clear the inherited query options or hash route this way. The URL getters return an empty string for both absent and explicitly empty values. Check whether the target supplied each delimiter before copying the base value, and add tests for empty overrides. --- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fixed in 5041210: an empty query or hash in the target clears that part of the base url.

… and hash Co-authored-by: Gabe <gpavanello@thefork.com>

…hash Co-authored-by: Gabe <gpavanello@thefork.com>

gabe-bots · 2026-10-26T09:21:37Z

@greptileai review

gabe-bots Bot added the needs-gabe Needs Gabe's decision before work continues label Oct 26, 2026

github-actions Bot added the risk:t2-hard label Oct 26, 2026

greptile-apps Bot reviewed Oct 26, 2026

View reviewed changes

cursoragent and others added 2 commits October 26, 2026 10:18

Resolve a relative goto against the base directory and keep its query…

2ca6a86

… and hash Co-authored-by: Gabe <gpavanello@thefork.com>

Keep base credentials on a relative goto and honor an empty query or …

5041210

…hash Co-authored-by: Gabe <gpavanello@thefork.com>

gabe4coding force-pushed the quality/108-goto-query branch from 84d2727 to 5041210 Compare October 26, 2026 09:18

Merge branch 'main' into quality/108-goto-query

76aa42d

gabe4coding merged commit ed0e5c1 into main Oct 26, 2026
7 checks passed

gabe4coding deleted the quality/108-goto-query branch October 26, 2026 10:27

Navigation Menu

Repository navigation

goto: keep the app path when the base url has a query or hash (#108) - #116

goto: keep the app path when the base url has a query or hash (#108)#116
gabe4coding merged 3 commits into
mainfrom
quality/108-goto-query

gabe-bots Bot commented Oct 26, 2026 •

edited

Loading

Uh oh!

gabe-bots Bot commented Oct 26, 2026

Uh oh!

gabe4coding commented Oct 26, 2026

Uh oh!

greptile-apps Bot commented Oct 26, 2026 •

edited

Loading

Summary

Uh oh!

greptile-apps Bot Oct 26, 2026

Uh oh!

gabe-bots Bot Oct 26, 2026

Uh oh!

greptile-apps Bot Oct 26, 2026

Uh oh!

gabe-bots Bot Oct 26, 2026

Uh oh!

gabe-bots Bot commented Oct 26, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		if (!resolved.search) resolved.search = parsed.search;
		if (!resolved.hash) resolved.hash = parsed.hash;

Conversation

gabe-bots Bot commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Intent

Drift

Decisions

Evidence

Review round 1

Reading map

Stack

Uh oh!

gabe-bots Bot commented Oct 26, 2026

Uh oh!

gabe4coding commented Oct 26, 2026

Uh oh!

greptile-apps Bot commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 4/5

Findings

Summary

Uh oh!

greptile-apps Bot Oct 26, 2026

Choose a reason for hiding this comment

Uh oh!

gabe-bots Bot Oct 26, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 26, 2026

Choose a reason for hiding this comment

Uh oh!

gabe-bots Bot Oct 26, 2026

Choose a reason for hiding this comment

Uh oh!

gabe-bots Bot commented Oct 26, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gabe-bots Bot commented Oct 26, 2026 •

edited

Loading

greptile-apps Bot commented Oct 26, 2026 •

edited

Loading