[gabe-bots]

Step 2/3 of quality/108-goto-query. Previous: quality/108-goto-query. Next: quality/109-long-context-note.

Part of #107

Intent

A fixed id that only contains a useId fragment stays in the shape hash. A no-judge replay of swapped buttons is inconclusive.

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  id["aria-controls value"] --> token["whole useId token?"]
  token -->|yes| drop["drop the attribute from the hash"]
  token -->|no| keep["keep tab_r_1_panel in the hash"]
  keep --> swap["ids swap on reload"]
  swap --> miss["shapes differ"]
  miss --> stop["no-judge click is inconclusive"]

Loading

Drift

The issue text says the whole attribute value. This branch uses token bounds, so aria-labelledby=":r1: :r2:" still matches. That is the brief’s rule.

Decisions

• LOCK_VERSION goes from 2 to 3. New lock files are version 3. plain ignores a version 2 file. A version 1 file still replays locators. Door: one-way. Old version 2 locks re-record once.
• GENERATED_ID keeps the old loose match, so the id strategy still skips tab_r_1_panel. Door: two-way.
• No e2e spec. The site cannot tell record from replay, and a real swap is inconclusive in no-judge. Door: two-way.

Evidence

Before: both buttons hash to 71ca4835…aaa683, equal true. Lock replay click status pass with (replayed).

After: hashes differ, equal false. menu:r1:list and menu:r2:list differ too. The two make it fail tests pass. npm run verify: 580 pass, 0 fail.

Locator benchmark on this branch: 144/144 locators, wrong hits 0, including use-id-regenerated. main was not re-run.

The reload assertion in record-locator.test.ts now uses the next real id (_r_6n_ to _r_6o_, :r2:, «r4», base-ui-_r_6o_, radix-:r3:, headlessui-menu-button-2). `${id}x` is no longer a useId token.

Review round 1

Before: a version 2 lock replayed the click as pass with (replayed). Fail-first: 1 fail.

After: that lock makes the click inconclusive. The detail matches no recorded locator. No step is marked (replayed). New files are version 3. npm run verify: 584 pass, 0 fail. Head e5550b7. The branch was rebased onto main after #115 merged, so verify ran on the commits before the rebase.

Reading map

• Tests changed: src/browser/record-locator.test.ts, src/browser/lock.test.ts.
• Lock format: LOCK_VERSION is 3.

Stack

Step 2/3 of quality/108-goto-query. Previous: quality/108-goto-query. Next: quality/109-long-context-note.

[gabe-bots]

@greptileai review

[gabe-bots]

Stack: merge 116 first. This branch includes its commits.

[gabe4coding]

@greptile review

[greptile-apps]

Confidence Score: 4/5

[Medium impact] Refines how element IDs are classified and URL navigation works.

The PR appears safe to merge, with a non-blocking fix needed for explicit empty query and hash overrides.

Findings

1.  Empty URL overrides are ignored ▶

Fix with agent prompt

### Issue 1
src/browser/steps.ts:180-181
`resolveUrl` restores the base query or hash even when the target explicitly clears it. With base `https://host/app?filter=active#old`, target `/login?` gets `filter=active` again, and `/login#` gets `old` again. Specs trying to clear a filter or anchor therefore keep the old value.

Check whether the target contains each delimiter rather than whether `resolved.search` or `resolved.hash` is nonempty. Add tests for explicit empty overrides.

```suggestion
  if (!relative.split('#')[0].includes('?')) resolved.search = parsed.search;
  if (!relative.includes('#')) resolved.hash = parsed.hash;
```

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Keeps fixed IDs containing a useId fragment in the shape hash and adds swapped-button replay coverage.

• Position-based replay keeps fixed ID fragments to spot swapped buttons.
• Relative goto keeps the app path and base query or hash.

Intentional choices acknowledged by gabe-bots[bot]: keep LOCK_VERSION at 2, keep loose GENERATED_ID matching, and omit a new shape end-to-end spec because the fixture cannot distinguish recording from replay. Token-bound matching, including multiple generated references, is also intentional.

_{Reviews (1) · Last reviewed commit: "Merge quality/108-goto-query into qualit..." · Reviewed by Greptile}

[greptile-apps]

Empty URL overrides are ignored

resolveUrl restores the base query or hash even when the target explicitly clears it. With base https://host/app?filter=active#old, target /login? gets filter=active again, and /login# gets old again. Specs trying to clear a filter or anchor therefore keep the old value.

Check whether the target contains each delimiter rather than whether resolved.search or resolved.hash is nonempty. Add tests for explicit empty overrides.

Suggested change

	if (!resolved.search) resolved.search = parsed.search;
	if (!resolved.hash) resolved.hash = parsed.hash;
	if (!relative.split('#')[0].includes('?')) resolved.search = parsed.search;
	if (!relative.includes('#')) resolved.hash = parsed.hash;

Prompt To Fix With AI

This is a comment left during a code review.
Path: src/browser/steps.ts
Line: 180-181

Comment:
**Empty URL overrides are ignored**

`resolveUrl` restores the base query or hash even when the target explicitly clears it. With base `https://host/app?filter=active#old`, target `/login?` gets `filter=active` again, and `/login#` gets `old` again. Specs trying to clear a filter or anchor therefore keep the old value.

Check whether the target contains each delimiter rather than whether `resolved.search` or `resolved.hash` is nonempty. Add tests for explicit empty overrides.

```suggestion
  if (!relative.split('#')[0].includes('?')) resolved.search = parsed.search;
  if (!relative.includes('#')) resolved.hash = parsed.hash;
```

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

[gabe-bots]

Fixed in bbc0183: an empty query or hash in the target clears that part of the base url.

[gabe-bots]

@greptileai review