Repository navigation
Require the plugin version to be above the tip of origin/main too - #56
Merged
Merged
Conversation
The version test compared only with the merge base. Two branches cut from the same main could both raise 0.11.3 to 0.11.4 and pass; after the first merged, the second shipped other cached files under the same version, and the per-version plugin cache never copied them. When the cached files change, the new version must now be above the version at the merge base and at the tip of origin/main. The CI skip and fail rules for a missing origin/main stay the same. A fast self-test covers the comparison, and CODING_STANDARDS.md says to merge main just before the PR merges, because the test sees only the main it fetched. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017PU3Bi7LSMdy1ByFedCJdR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test_a_change_to_the_cached_files_raises_the_versioncompared the version only with the merge base. Two branches from the samemain(0.11.3) can both raise to 0.11.4 and pass. After the first branch merges, the second branch ships other cached files under the same version. The per-version plugin cache of Claude Code and Codex then does not copy them. This happened on 2026-10-13.Change
tests/test_plugin.py: when the cached files (CACHED) change, the new version must be above the version at the merge base and at the tip oforigin/main. The failure message names each version that blocks. The CI skip and fail rules for a missingorigin/maindo not change.tests/test_plugin.py: new self-testtest_the_new_version_must_be_above_each_old_onefor the comparison. It has no git setup.CODING_STANDARDS.md: the version must be above the version onmainnow. Mergemainjust before the PR merges, because the test sees only themainit fetched.Limit
The test checks the
mainthat CI fetched. If a branch passed CI before another branch merged, the test catches the conflict only when CI runs again. To close this gap, turn on "require branches to be up to date" or a merge queue in the GitHub settings.Verification
scripts/test --all: 1720 passed, 13 skipped.origin/mainref that was restored after:mainat 0.11.4: passes.maintip already at 0.11.5: fails ("not above 0.11.5 on origin/main"). The old test passed this case./verify: SKIP (the change is to tests and docs only).🤖 Generated with Claude Code
https://claude.ai/code/session_017PU3Bi7LSMdy1ByFedCJdR
Generated by Claude Code