Skip to content

Add tests for conflicts.py - #15

Merged
gabe4coding merged 1 commit into
mainfrom
quality/shall-conflicts-tests
Oct 19, 2026
Merged

gabe4coding merged 1 commit into
mainfrom
quality/shall-conflicts-tests

Conversation

@gabe-bots

@gabe-bots gabe-bots Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor
  1. Adds tests for conflicts.py, raising its coverage from 0 to 64%.
  2. Also fixes two lint nits. No logic changes.
  3. make test (207 pass), make check, make self-check and make test-plugin all pass. Low risk; it goes in the Friday digest.

Prepared by Quality, opened by gabe-bots.

Co-authored-by: Gabe <gpavanello@thefork.com>
@gabe-bots

gabe-bots Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

@greptileai review

@greptile-apps

greptile-apps Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

Adds five tests for compare in conflicts.py.

  • Conflict comparisons now have tests for their finding rules.
  • The review prompt and stop-word list get small lint cleanups.

Reviews (1) · Last reviewed commit: "Add tests for conflicts.py; fix two lint..." · Reviewed by Greptile

@gabe4coding
gabe4coding merged commit 7a705f4 into main Oct 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants