feat(cli): add --visibility and --comments to share and watch - #99
Merged
Conversation
Omit each JSON key unless the flag is set. --private aliases --visibility private; --no-comments sends comment_access=disabled. gander list shows COMMENTING and VISIBILITY. Closes #98
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--visibility=anyone|private|hidden,--private,--comments=anyone|private|disabled, and--no-commentstogander shareandgander watch.flag.Visit), so a content refresh does not clobber stored ACL.--privatesends"doc_visibility":"private".--no-commentssends"comment_access":"disabled"(not private).--comments anyonewith private/hidden,--no-commentswith--comments anyone|private, conflicting--private/--visibility) fail before HTTP.gandermd does not support --comments|--visibility; upgrade the server) instead of printing a URL.--visibility=hiddenstill prints the share URL but does not open the browser (viewer is 404 for everyone).gander listgains COMMENTING and VISIBILITY columns. Watch PUTs stay{content}only.Related Issue
Closes #98
Supersedes #96 (and closed PR #97). Do not merge
feat/96-share-comment-access; that branch encoded--comments teamand--comment-visibility.Pairing
gandermd wave 2 is on
main(PRs 79–86).readJSON+DisallowUnknownFields400s these keys against an older server — ship this CLI after that stack is on:latest.doc_visibility)comment_access)Testing
All green. Coverage includes omit vs send,
--no-comments≡--comments disabled,--privatebody,--visibility=hidden(no browser open), watch PUT content-only, invalid combos before HTTP, old-server echo check, and list columns.Notes
No invite subcommand in v1. Token-only authors change policy by re-sharing with flags. No Bearer PATCH client in this PR.