Repository navigation
chore(workflows): move the five image pins to what #88's build published - #89
Merged
Merged
Conversation
The first refresh prompted by the check rather than by remembering. #88 added a `pins` job to build-toolbox.yml; its own merge triggered a rebuild, the job ran, and it went red naming all five stale pins with the digest each should move to. A true positive on first firing, because #86 and #87 had already left them behind. security-toolbox-base d2f1d6b33d9c -> 9be060794ecb gha-toolbox 7e6558f3b46c -> 4cef3443acbd sast-toolbox 6bf6d9aafd5a -> edfd4db8752a iac-toolbox bc4198b93fcc -> 08e1338df20c skill-audit-toolbox c10bc17412a2 -> f5f99b96668f Digests taken from the job's own annotations, which report steps.build.outputs.digest from the run that published them. No local pull and no registry lookup, so neither the index-vs-manifest ambiguity from #82 nor a hand-copied digest can get in. Verified behind the new pins: base ships trufflehog 3.99.3, betterleaks 1.9.0, osv-scanner 2.7.0 and syft 1.55.0, with pip 26.2.2 vendoring certifi 2026.10.19, so #87's CVE fix is actually in what callers now get. skill-audit ships SkillSpector v2.13.0. One thing the check cannot currently survive: #86's build failed on a cosign/Rekor 409, "an equivalent entry already exists in the transparency log", because toolbox/gha was unchanged so gha-toolbox rebuilt to a byte identical digest that was already signed. A failed domain arm skips the pins job rather than running it. Benign cause, but it means a reproducible rebuild can silence the check. Noted, not fixed here. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first pin refresh prompted by the check rather than by someone remembering.
#88 added the
pinsjob. Its own merge touched.github/workflows/build-toolbox.yml, which is in that workflow's trigger paths, so it rebuilt, the job ran, and it went red naming all five stale pins. A true positive on first firing, because #86 and #87 had already left them behind.Where the digests came from
The job's own annotations, which report
steps.build.outputs.digestfrom the run that published them. Each annotation names the file, the stale pin and the digest to move to, so the refresh is mechanical:No local pull and no registry lookup, so neither the index-versus-manifest ambiguity that put two of five pins in wrong in #82, nor a hand-copied digest, can get in. I parsed the annotations and then cross-checked every pin against the published value.
Verified behind the new pins
Ran the images rather than trusting that a green build implies the right contents:
trufflehog 3.99.3,betterleaks 1.9.0,osv-scanner 2.7.0,syft 1.55.0, andpip 26.2.2vendoringcertifi 2026.10.19— so fix(toolbox): upgrade pip so its vendored certifi is not the CRITICAL #87's CVE fix is genuinely in what callers now get, which was the whole point of that PRSkillSpector v2.13.0One limitation the check has, found by it happening
#86's build failed on a cosign/Rekor 409: "an equivalent entry already exists in the transparency log".
toolbox/ghawas unchanged, sogha-toolboxrebuilt to a byte-identical digest that had already been signed.That is benign in itself, and incidentally proves the builds are reproducible when inputs do not change. But a failed
domainarm skips thepinsjob rather than running it, so a reproducible rebuild can silence the check. Theneeds: [base, domain]wants anif:that tolerates a partial build, or the sign step wants to treat a 409 as success.Not fixed here, because this PR should stay a pin refresh. Worth doing before the next time a tool bump touches only some images.
🤖 Generated with Claude Code