Fix incorrect solution in the Registers section - #186
Conversation
|
@OnStarPrograms could you take a look? |
avivace
left a comment
There was a problem hiding this comment.
I'm a bit confused, you seem to be submitting a fix for the 'solution' of such challenge but you're also changing the problem statement..
Is this intended ?
|
Yes, it is intended. In the original exercise the problem statement uses the numbers 16 and 14, but the solution proceeds as if the numbers were 256 and 14. Moreover, the solution is incorrect even when using 256 and 14. I decided to use 256 because I think it makes the exercise more interesting. |
quinnyo
left a comment
There was a problem hiding this comment.
Using 256 (or any number wider than 8 bits) as the number to load into BC makes sense.
This makes the challenge about the relationship between the 16-bit register pair (BC) and its component 8-bit registers (C). (Which seems to have been the original intent, at least in part.)
The changes to the wording and formatting in the answer are a definite improvement.
LGTM
Fix the incorrect solution in answer 1 on the "Registers" page.