Skip to content

Fix incorrect solution in the Registers section - #186

Open
andreamauri31g wants to merge 1 commit into
gbdev:masterfrom
andreamauri31g:fix/registers
Open

Fix incorrect solution in the Registers section#186
andreamauri31g wants to merge 1 commit into
gbdev:masterfrom
andreamauri31g:fix/registers

Conversation

@andreamauri31g

Copy link
Copy Markdown

Fix the incorrect solution in answer 1 on the "Registers" page.

@avivace

avivace commented Aug 20, 2026

Copy link
Copy Markdown
Member

@OnStarPrograms could you take a look?

@avivace avivace left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused, you seem to be submitting a fix for the 'solution' of such challenge but you're also changing the problem statement..

Is this intended ?

@andreamauri31g

Copy link
Copy Markdown
Author

Yes, it is intended. In the original exercise the problem statement uses the numbers 16 and 14, but the solution proceeds as if the numbers were 256 and 14. Moreover, the solution is incorrect even when using 256 and 14. I decided to use 256 because I think it makes the exercise more interesting.

@quinnyo quinnyo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using 256 (or any number wider than 8 bits) as the number to load into BC makes sense.
This makes the challenge about the relationship between the 16-bit register pair (BC) and its component 8-bit registers (C). (Which seems to have been the original intent, at least in part.)

The changes to the wording and formatting in the answer are a definite improvement.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants