Repository navigation
Ship scripts/native-libraries.mjs in the package - #12
Conversation
122f06b moved the brotli and vcpkg library lookup into scripts/native-libraries.mjs and imported it from build.mjs, but the package's files list names each script individually and was not given the new one. An installed node-compat therefore fails every build with ERR_MODULE_NOT_FOUND before compiling anything. Found by the compiler's release suite: test/node-project.mjs packs this checkout, installs it beside the packed compiler and builds a project through it. It failed on the missing module and passes with this change.
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Published file list package.json |
The published file list now includes scripts/native-libraries.mjs. |
Priority:
Estimated code review effort: 1 (Trivial) | ~2 minutes
Change: Bug fix
Suggested reviewers: puskuruk
Merge Risk: 
f643f
-
No actionable merge-blocking risk remains.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: including scripts/native-libraries.mjs in the published package. Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
scripts/build.mjsimports./native-libraries.mjs(added in 122f06b, #11), butpackage.jsonfileslists scripts one by one and doesn't include it. An installed node-compat fails every build withERR_MODULE_NOT_FOUND.Found by the compiler release suite's
test/node-project.mjs, which packs this checkout, installs it and builds a project through it. It fails on main and passes with this change.npm pack --dry-runnow lists the file.Summary by CodeRabbit